From: Oleg Nesterov <oleg@redhat.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Patrick Donnelly <batrick@batbytes.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
open list <linux-kernel@vger.kernel.org>,
openSUSE Kernel <opensuse-kernel@opensuse.org>
Subject: Re: [PATCH v4] tty: add missing rcu_read_lock for task_pgrp
Date: Mon, 20 Jul 2015 21:40:51 +0200 [thread overview]
Message-ID: <20150720194051.GA21204@redhat.com> (raw)
In-Reply-To: <55ACBEBC.5060505@suse.cz>
On 07/20, Jiri Slaby wrote:
>
> CC Oleg
>
> On 07/13/2015, 12:51 AM, Patrick Donnelly wrote:
> > task_pgrp requires an rcu or tasklist lock to be obtained if the returned pid
> > is to be dereferenced, which kill_pgrp does. Obtain an RCU lock for the
> > duration of use.
Look like, this change is right.
But perhaps we should a simple helper for drivers/tty/ which takes rcu
lock, sends a signal to task_pgrp(current), and sets TIF_SIGPENDING?
I won't insist of course, I am fine either way.
Oleg.
prev parent reply other threads:[~2015-07-20 19:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-27 21:17 [PATCH 1/2] Add missing rcu_read_lock for task_pgrp Patrick Donnelly
2015-06-27 21:17 ` [PATCH 2/2] Check tcsetpgrp p is a process group Patrick Donnelly
2015-06-27 23:26 ` Greg Kroah-Hartman
2015-06-28 0:53 ` Patrick Donnelly
2015-06-27 23:27 ` Greg Kroah-Hartman
2015-06-27 23:25 ` [PATCH 1/2] Add missing rcu_read_lock for task_pgrp Greg Kroah-Hartman
2015-06-28 0:51 ` [PATCH v2 1/2] tty: add " Patrick Donnelly
2015-06-28 0:51 ` [PATCH v2 2/2] tty: check tcsetpgrp p is a process group Patrick Donnelly
2015-06-28 16:07 ` Peter Hurley
2015-06-29 1:27 ` Patrick Donnelly
2015-06-28 15:23 ` [PATCH v2 1/2] tty: add missing rcu_read_lock for task_pgrp Peter Hurley
2015-06-28 17:20 ` Patrick Donnelly
2015-06-28 19:21 ` Peter Hurley
2015-06-28 19:27 ` Peter Hurley
2015-06-29 23:38 ` Patrick Donnelly
2015-06-29 23:59 ` [PATCH v3] " Patrick Donnelly
2015-07-09 2:07 ` Peter Hurley
2015-07-12 2:05 ` Peter Hurley
2015-07-12 22:42 ` Patrick Donnelly
2015-07-12 22:51 ` [PATCH v4] " Patrick Donnelly
2015-07-13 0:35 ` Peter Hurley
2015-07-20 9:26 ` Jiri Slaby
2015-07-20 19:40 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150720194051.GA21204@redhat.com \
--to=oleg@redhat.com \
--cc=batrick@batbytes.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=opensuse-kernel@opensuse.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).