From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756891AbbGTV60 (ORCPT ); Mon, 20 Jul 2015 17:58:26 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:43616 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752455AbbGTV6Z (ORCPT ); Mon, 20 Jul 2015 17:58:25 -0400 Date: Mon, 20 Jul 2015 14:58:24 -0700 From: Darren Hart To: Azael Avalos Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] toshiba_acpi: Adapt /proc/acpi/toshiba/keys to TOS1900 devices Message-ID: <20150720215824.GD34611@vmdeb7> References: <1437168086-4197-1-git-send-email-coproscefalo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437168086-4197-1-git-send-email-coproscefalo@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 17, 2015 at 03:21:26PM -0600, Azael Avalos wrote: > Since the introduction of TOS1900 devices support to the driver, the > "keys" entry under the proc directory was broken, given that it only > handled TOS620X devices accordingly. > > This patch adapts the code to show the hotkey values of TOS1900 > devices too, and in case some programs are still using that interface, > hotkeys reporting should now work on these devices. > > Signed-off-by: Azael Avalos > --- > Darren: > > While checking the driver for the ninja-check report you sent me, > it remiended me of the changes made on this patch, and while I was > at it, "solved" a couple of the issues reported by such check ;-) > > I'm still digging into the code, and will provide a patch later on > with all the needed changes :-) Looks good, thanks Azael. -- Darren Hart Intel Open Source Technology Center