From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Dudley Du <dudl@cypress.com>
Cc: mark.rutland@arm.com, robh+dt@kernel.org, rydberg@euromail.se,
bleung@google.com, jmmahler@gmail.com,
devicetree@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/7] input: cyapa: add proximity function support for gen5 and gen6 modules
Date: Mon, 20 Jul 2015 17:06:58 -0700 [thread overview]
Message-ID: <20150721000658.GD15528@dtor-ws> (raw)
In-Reply-To: <1434358897-24668-4-git-send-email-dudl@cypress.com>
Hi Dudley,
On Mon, Jun 15, 2015 at 05:01:33PM +0800, Dudley Du wrote:
>
> +static void cyapa_pip_report_proximity(struct cyapa *cyapa,
> + const struct cyapa_pip_report_data *report_data)
> +{
> + struct input_dev *input = cyapa->input;
> + u8 distance = report_data->report_head[PIP_PROXIMITY_DISTANCE_OFFSET] &
> + PIP_PROXIMITY_DISTANCE_MASK;
> +
> + input_report_abs(input, ABS_MT_DISTANCE, distance);
> + input_sync(input);
It looks like the distance reported by the hardware is not per-contact
(i.e. it can not tell that we had 2 fingers on surface and the 2nd one
was lifted and is now hovering over the surface), so we should be using
ABS_DISTANCE, not ABS_MT_DISTANCE.
I can adjust it here, no need to resend.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2015-07-21 0:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 9:01 [PATCH v1 0/7] instruction of cyapa gen6 and proximity patches Dudley Du
2015-06-15 9:01 ` [PATCH v1 1/7] input: cyapa: change strings of gen5 to pip in the name when they are shared Dudley Du
2015-07-21 0:03 ` Dmitry Torokhov
2015-06-15 9:01 ` [PATCH v1 2/7] input: cyapa: add gen6 device module support in driver Dudley Du
2015-07-21 0:04 ` Dmitry Torokhov
2015-06-15 9:01 ` [PATCH v1 3/7] input: cyapa: add proximity function support for gen5 and gen6 modules Dudley Du
2015-07-21 0:06 ` Dmitry Torokhov [this message]
2015-07-21 1:43 ` Dudley Du
2015-06-15 9:01 ` [PATCH v1 4/7] input: cyapa: fully support runtime suspend power management Dudley Du
2015-07-21 0:13 ` Dmitry Torokhov
2015-06-15 9:01 ` [PATCH v1 5/7] input: cyapa: add proximity and interrupt sysfs interfaces support Dudley Du
2015-06-15 9:01 ` [PATCH v1 6/7] input: cyapa: add of match device support and description document Dudley Du
2015-07-21 0:15 ` Dmitry Torokhov
2015-07-21 2:15 ` Dudley Du
2015-06-15 9:01 ` [PATCH v1 7/7] input: cyapa: add CYAP0002 Gen6 device for ACPI configuration Dudley Du
2015-07-21 0:17 ` Dmitry Torokhov
2015-06-17 22:09 ` [PATCH v1 0/7] instruction of cyapa gen6 and proximity patches Jeremiah Mahler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150721000658.GD15528@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=bleung@google.com \
--cc=devicetree@vger.kernel.org \
--cc=dudl@cypress.com \
--cc=jmmahler@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox