From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757344AbbGUBC7 (ORCPT ); Mon, 20 Jul 2015 21:02:59 -0400 Received: from e34.co.us.ibm.com ([32.97.110.152]:40870 "EHLO e34.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757086AbbGUBC6 (ORCPT ); Mon, 20 Jul 2015 21:02:58 -0400 X-Helo: d03dlp01.boulder.ibm.com X-MailFrom: paulmck@linux.vnet.ibm.com X-RcptTo: linux-kernel@vger.kernel.org Date: Mon, 20 Jul 2015 18:02:52 -0700 From: "Paul E. McKenney" To: Joe Perches Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, dvhart@linux.intel.com, fweisbec@gmail.com, oleg@redhat.com, bobby.prani@gmail.com, Andy Whitcroft Subject: Re: [PATCH tip/core/rcu 15/16] scripts: Make checkpatch.pl warn on expedited RCU grace periods Message-ID: <20150721010251.GP3717@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <20150717221949.GA12304@linux.vnet.ibm.com> <1437171616-13832-1-git-send-email-paulmck@linux.vnet.ibm.com> <1437171616-13832-15-git-send-email-paulmck@linux.vnet.ibm.com> <1437172674.2495.60.camel@perches.com> <20150721004104.GN3717@linux.vnet.ibm.com> <1437439720.28284.4.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437439720.28284.4.camel@perches.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15072101-0017-0000-0000-00000C7C414F Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 20, 2015 at 05:48:40PM -0700, Joe Perches wrote: > On Mon, 2015-07-20 at 17:41 -0700, Paul E. McKenney wrote: > > On Fri, Jul 17, 2015 at 03:37:54PM -0700, Joe Perches wrote: > > > It'd be faster perl without capture groups: > > > > > > if ($line =~ /\b(?:synchronize_(?:rcu|sched)_expedited)\s*\(/) { > > > > Fair enough, but this pattern is used rather heavily in this script, > > and I don't trust my perl enough to want to create a new pattern. > > > > I see a couple of possible ways forward: > > > > 1. I hand this patch off to you, and you update it as you deem fit. > > > > 2. I push the patch as is (after the fix below) and you update > > checkpatch as a whole to use the more efficient code. > > > > How would you like to proceed? > > Push and fix would work fine. Very good, will do! Thanx, Paul