From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754213AbbGUCbU (ORCPT ); Mon, 20 Jul 2015 22:31:20 -0400 Received: from mail-pd0-f172.google.com ([209.85.192.172]:34997 "EHLO mail-pd0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753236AbbGUCbS (ORCPT ); Mon, 20 Jul 2015 22:31:18 -0400 Date: Tue, 21 Jul 2015 08:01:14 +0530 From: Viresh Kumar To: Guenter Roeck Cc: Daniel Lezcano , Laurent Pinchart , Linux-sh list , "linux-kernel@vger.kernel.org" Subject: Re: Traceback in -next due to commit 'clockevents/drivers/sh_tmu: Migrate to new 'set-state' interface' Message-ID: <20150721023114.GD4994@linux> References: <55AD6314.2050000@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55AD6314.2050000@roeck-us.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20-07-15, 14:07, Guenter Roeck wrote: > Hi, > > Commit 991a7f4970ed1 ("clockevents/drivers/sh_tmu: Migrate to new 'set-state' interface") > in -next causes the following traceback. This is seen with qemu runs for the sh target. > > ------------[ cut here ]------------ > WARNING: at drivers/clocksource/sh_tmu.c:202 > Modules linked in: Can you please try this: diff --git a/drivers/clocksource/sh_tmu.c b/drivers/clocksource/sh_tmu.c index 43c98143f79a..469e776ec17a 100644 --- a/drivers/clocksource/sh_tmu.c +++ b/drivers/clocksource/sh_tmu.c @@ -362,7 +362,8 @@ static int sh_tmu_clock_event_shutdown(struct clock_event_device *ced) { struct sh_tmu_channel *ch = ced_to_sh_tmu(ced); - sh_tmu_disable(ch); + if (clockevent_state_oneshot(ced) || clockevent_state_periodic(ced)) + sh_tmu_disable(ch); return 0; } -- viresh