* [PATCH] x86: hd0_info and hd1_info are obsolete and unused fields
@ 2015-07-20 16:51 Paolo Pisati
2015-07-21 6:17 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Pisati @ 2015-07-20 16:51 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: Ingo Molnar, H. Peter Anvin, x86, linux-kernel
hd0_info and hd1_info are not used anymore, don't reference them in the code
Signed-off-by: Paolo Pisati <p.pisati@gmail.com>
---
arch/x86/kernel/kexec-bzimage64.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/x86/kernel/kexec-bzimage64.c b/arch/x86/kernel/kexec-bzimage64.c
index 3666a84..c0ae428 100644
--- a/arch/x86/kernel/kexec-bzimage64.c
+++ b/arch/x86/kernel/kexec-bzimage64.c
@@ -218,10 +218,6 @@ setup_boot_parameters(struct kimage *image, struct boot_params *params,
/* Default APM info */
memset(¶ms->apm_bios_info, 0, sizeof(params->apm_bios_info));
- /* Default drive info */
- memset(¶ms->hd0_info, 0, sizeof(params->hd0_info));
- memset(¶ms->hd1_info, 0, sizeof(params->hd1_info));
-
if (image->type == KEXEC_TYPE_CRASH) {
ret = crash_setup_memmap_entries(image, params);
if (ret)
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] x86: hd0_info and hd1_info are obsolete and unused fields
2015-07-20 16:51 [PATCH] x86: hd0_info and hd1_info are obsolete and unused fields Paolo Pisati
@ 2015-07-21 6:17 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2015-07-21 6:17 UTC (permalink / raw)
To: Paolo Pisati
Cc: Thomas Gleixner, H. Peter Anvin, x86, linux-kernel,
Borislav Petkov
* Paolo Pisati <p.pisati@gmail.com> wrote:
> hd0_info and hd1_info are not used anymore, don't reference them in the code
>
> Signed-off-by: Paolo Pisati <p.pisati@gmail.com>
> ---
> arch/x86/kernel/kexec-bzimage64.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/x86/kernel/kexec-bzimage64.c b/arch/x86/kernel/kexec-bzimage64.c
> index 3666a84..c0ae428 100644
> --- a/arch/x86/kernel/kexec-bzimage64.c
> +++ b/arch/x86/kernel/kexec-bzimage64.c
> @@ -218,10 +218,6 @@ setup_boot_parameters(struct kimage *image, struct boot_params *params,
> /* Default APM info */
> memset(¶ms->apm_bios_info, 0, sizeof(params->apm_bios_info));
>
> - /* Default drive info */
> - memset(¶ms->hd0_info, 0, sizeof(params->hd0_info));
> - memset(¶ms->hd1_info, 0, sizeof(params->hd1_info));
> -
> if (image->type == KEXEC_TYPE_CRASH) {
> ret = crash_setup_memmap_entries(image, params);
> if (ret)
But they are not unused: we pass them to secondary kernel images, via kcrash for
example.
So it makes sense to zero out these parameters.
Thanks,
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-21 6:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-20 16:51 [PATCH] x86: hd0_info and hd1_info are obsolete and unused fields Paolo Pisati
2015-07-21 6:17 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox