From: Ingo Molnar <mingo@kernel.org>
To: Brian Gerst <brgerst@gmail.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
"H. Peter Anvin" <hpa@zytor.com>,
Denys Vlasenko <dvlasenk@redhat.com>,
Andy Lutomirski <luto@amacapital.net>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 4/7] x86/vm86: Move vm86 fields out of thread_struct
Date: Tue, 21 Jul 2015 08:31:55 +0200 [thread overview]
Message-ID: <20150721063155.GA7949@gmail.com> (raw)
In-Reply-To: <20150721062858.GA5110@gmail.com>
* Ingo Molnar <mingo@kernel.org> wrote:
> * Brian Gerst <brgerst@gmail.com> wrote:
>
> > Allocate a separate structure for the vm86 fields.
>
> Why is this allocated dynamically? This structure is not very large, and a hole
> in thread_struct isn't that big of an issue - compared to additional fragility
> introduced by the (mostly untested by normal apps) dynamic allocation here ...
>
> I don't mind the introduction of the sub-structure in itself, but please embedd
> it in thread_struct.
Otherwise I have no objections to the rest of the series, nice fixes!
Thanks,
Ingo
next prev parent reply other threads:[~2015-07-21 6:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 1:09 [PATCH v3] x86: vm86 cleanups Brian Gerst
2015-07-20 1:09 ` [PATCH 1/7] x86/vm86: Clean up saved_fs/gs Brian Gerst
2015-07-21 9:38 ` [tip:x86/asm] x86/entry/vm86: " tip-bot for Brian Gerst
2015-07-20 1:09 ` [PATCH 2/7] x86/vm86: Preserve orig_ax Brian Gerst
2015-07-21 9:39 ` [tip:x86/asm] x86/entry/vm86: Preserve 'orig_ax' tip-bot for Brian Gerst
2015-07-20 1:09 ` [PATCH 3/7] x86/vm86: Move userspace accesses to do_sys_vm86() Brian Gerst
2015-07-21 9:39 ` [tip:x86/asm] x86/entry/vm86: " tip-bot for Brian Gerst
2015-07-20 1:09 ` [PATCH 4/7] x86/vm86: Move vm86 fields out of thread_struct Brian Gerst
2015-07-21 6:28 ` Ingo Molnar
2015-07-21 6:30 ` Andy Lutomirski
2015-07-21 6:35 ` Ingo Molnar
2015-07-21 6:31 ` Ingo Molnar [this message]
2015-07-21 7:11 ` Ingo Molnar
2015-07-21 15:30 ` Brian Gerst
2015-08-05 8:48 ` Ingo Molnar
2015-08-05 8:53 ` Linus Torvalds
2015-08-23 11:51 ` Ingo Molnar
2015-07-20 1:09 ` [PATCH 5/7] x86/vm86: Move fields from kernel_vm86_struct Brian Gerst
2015-07-20 1:09 ` [PATCH 6/7] x86/vm86: Eliminate kernel_vm86_struct Brian Gerst
2015-07-20 1:09 ` [PATCH 7/7] x86/vm86: Use the normal pt_regs area for vm86 Brian Gerst
-- strict thread matches above, loose matches on Subject: below --
2015-07-16 11:46 [PATCH v2] x86: vm86 cleanups Brian Gerst
2015-07-16 11:46 ` [PATCH 4/7] x86/vm86: Move vm86 fields out of thread_struct Brian Gerst
2015-07-17 19:01 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150721063155.GA7949@gmail.com \
--to=mingo@kernel.org \
--cc=brgerst@gmail.com \
--cc=dvlasenk@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).