From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, Rik van Riel <riel@redhat.com>,
Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH] sched/numa: Disable sched_numa_balancing on uma systems
Date: Tue, 21 Jul 2015 15:38:28 +0530 [thread overview]
Message-ID: <20150721100828.GA24741@linux.vnet.ibm.com> (raw)
In-Reply-To: <20150721075120.GB25542@gmail.com>
> > @@ -2059,22 +2059,18 @@ static void __sched_fork(unsigned long clone_flags, struct task_struct *p)
> > }
> >
> > #ifdef CONFIG_NUMA_BALANCING
> > -#ifdef CONFIG_SCHED_DEBUG
> > +__read_mostly bool sched_numa_balancing;
> > +
> > void set_numabalancing_state(bool enabled)
> > {
> > + sched_numa_balancing = enabled;
> > +#ifdef CONFIG_SCHED_DEBUG
> > if (enabled)
> > sched_feat_set("NUMA");
> > else
> > sched_feat_set("NO_NUMA");
>
> So why is the 'NUMA' sched_features option still twiddled? Your patch splits out a
> sched_numa_balancing flag - so the NUMA/NO_NUMA feature can go away, right?
>
I thought we could retain sched_feat so that we could enable/disable
sched numa balancing for debugging purposes similar to other sched
features if the kernel has been build with CONFIG_SCHED_DEBUG.
--
Thanks and Regards
Srikar Dronamraju
prev parent reply other threads:[~2015-07-21 10:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 16:42 [PATCH] sched/numa: Disable sched_numa_balancing on uma systems Srikar Dronamraju
2015-07-21 7:51 ` Ingo Molnar
2015-07-21 10:08 ` Srikar Dronamraju [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150721100828.GA24741@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox