From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755497AbbGUKJZ (ORCPT ); Tue, 21 Jul 2015 06:09:25 -0400 Received: from e28smtp02.in.ibm.com ([122.248.162.2]:43096 "EHLO e28smtp02.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754906AbbGUKJX (ORCPT ); Tue, 21 Jul 2015 06:09:23 -0400 X-Helo: d28dlp02.in.ibm.com X-MailFrom: srikar@linux.vnet.ibm.com X-RcptTo: linux-kernel@vger.kernel.org Date: Tue, 21 Jul 2015 15:38:28 +0530 From: Srikar Dronamraju To: Ingo Molnar Cc: Peter Zijlstra , linux-kernel@vger.kernel.org, Rik van Riel , Mel Gorman Subject: Re: [PATCH] sched/numa: Disable sched_numa_balancing on uma systems Message-ID: <20150721100828.GA24741@linux.vnet.ibm.com> Reply-To: Srikar Dronamraju References: <1436978557-24935-1-git-send-email-srikar@linux.vnet.ibm.com> <20150721075120.GB25542@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20150721075120.GB25542@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15072110-0005-0000-0000-00000688E846 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > @@ -2059,22 +2059,18 @@ static void __sched_fork(unsigned long clone_flags, struct task_struct *p) > > } > > > > #ifdef CONFIG_NUMA_BALANCING > > -#ifdef CONFIG_SCHED_DEBUG > > +__read_mostly bool sched_numa_balancing; > > + > > void set_numabalancing_state(bool enabled) > > { > > + sched_numa_balancing = enabled; > > +#ifdef CONFIG_SCHED_DEBUG > > if (enabled) > > sched_feat_set("NUMA"); > > else > > sched_feat_set("NO_NUMA"); > > So why is the 'NUMA' sched_features option still twiddled? Your patch splits out a > sched_numa_balancing flag - so the NUMA/NO_NUMA feature can go away, right? > I thought we could retain sched_feat so that we could enable/disable sched numa balancing for debugging purposes similar to other sched features if the kernel has been build with CONFIG_SCHED_DEBUG. -- Thanks and Regards Srikar Dronamraju