From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932730AbbGUOWA (ORCPT ); Tue, 21 Jul 2015 10:22:00 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:48630 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932117AbbGUOV6 (ORCPT ); Tue, 21 Jul 2015 10:21:58 -0400 Date: Tue, 21 Jul 2015 16:21:49 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Mark Brown Cc: Linus Walleij , Liam Girdwood , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Zhong , kernel@pengutronix.de, Krzysztof Kozlowski Subject: Re: [PATCH] regulator: rk808: make better use of the gpiod API Message-ID: <20150721142149.GC9981@pengutronix.de> References: <20150721132945.7ffc443b@canb.auug.org.au> <1437461993-14860-1-git-send-email-u.kleine-koenig@pengutronix.de> <20150721110415.GS11162@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150721110415.GS11162@sirena.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 21, 2015 at 12:04:15PM +0100, Mark Brown wrote: > On Tue, Jul 21, 2015 at 11:56:49AM +0200, Linus Walleij wrote: > > On Tue, Jul 21, 2015 at 8:59 AM, Uwe Kleine-König > > > > The gpiod functions include variants for managed gpiod resources. Use it > > > to simplify the remove function. > > > > As the driver handles a device node without a specification of dvs gpios > > > just fine, additionally use the variant of gpiod_get exactly for this > > > use case. This makes error checking more strict. > > > > As a third benefit this patch makes the driver use the flags parameter > > > of gpiod_get* which will not be optional any more after 4.2 and so > > > prevents a build failure when the respective gpiod commit is merged. > > > Reviewed-by: Linus Walleij > > > > Mark, please apply this. > > ...and reverted since it doesn't build as it's adding a use of a new API > which doesn't actually exist in Linus' tree yet (hopefully it's in > -next). I need a tag to pull if I'm going to use this patch. If you're refering to the build bot warning I got, too, then the problem is just a missing #include and the problem existed already before e.g. for gpiod_get_value with the .config used by the build bot. In reply to this mail I'll send a fixup patch for the missing include and a reworked version of my patch that fixes the reference leak pointed out by Krzysztof Kozlowski. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |