From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Antonio Borneo <borneo.antonio@gmail.com>,
Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>,
Andrew Duggan <aduggan@synaptics.com>,
Seth Forshee <seth.forshee@canonical.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hid: Drop owner assignment from i2c_driver
Date: Tue, 21 Jul 2015 13:39:24 -0400 [thread overview]
Message-ID: <20150721173924.GD6121@mail.corp.redhat.com> (raw)
In-Reply-To: <1436507466-19257-1-git-send-email-k.kozlowski@samsung.com>
On Jul 10 2015 or thereabouts, Krzysztof Kozlowski wrote:
> i2c_driver does not need to set an owner because i2c_register_driver()
> will set it.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> ---
BTW, Dmitry took the same in his tree, so I think we are safe here too.
Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cheers,
Benjamin
>
> The coccinelle script which generated the patch was sent here:
> http://www.spinics.net/lists/kernel/msg2029903.html
> ---
> drivers/hid/i2c-hid/i2c-hid.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
> index f77469d4edfb..dfd679647391 100644
> --- a/drivers/hid/i2c-hid/i2c-hid.c
> +++ b/drivers/hid/i2c-hid/i2c-hid.c
> @@ -1167,7 +1167,6 @@ MODULE_DEVICE_TABLE(i2c, i2c_hid_id_table);
> static struct i2c_driver i2c_hid_driver = {
> .driver = {
> .name = "i2c_hid",
> - .owner = THIS_MODULE,
> .pm = &i2c_hid_pm,
> .acpi_match_table = ACPI_PTR(i2c_hid_acpi_match),
> .of_match_table = of_match_ptr(i2c_hid_of_match),
> --
> 1.9.1
>
prev parent reply other threads:[~2015-07-21 17:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 5:51 [PATCH] hid: Drop owner assignment from i2c_driver Krzysztof Kozlowski
2015-07-21 17:39 ` Benjamin Tissoires [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150721173924.GD6121@mail.corp.redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=aduggan@synaptics.com \
--cc=borneo.antonio@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=jkosina@suse.cz \
--cc=jmaneyrol@invensense.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=seth.forshee@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox