From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933494AbbGURj3 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 21 Jul 2015 13:39:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49318 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755728AbbGURj2 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 21 Jul 2015 13:39:28 -0400
Date: Tue, 21 Jul 2015 13:39:24 -0400
From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Antonio Borneo <borneo.antonio@gmail.com>,
        Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>,
        Andrew Duggan <aduggan@synaptics.com>,
        Seth Forshee <seth.forshee@canonical.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        "open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hid: Drop owner assignment from i2c_driver
Message-ID: <20150721173924.GD6121@mail.corp.redhat.com>
References: <1436507466-19257-1-git-send-email-k.kozlowski@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1436507466-19257-1-git-send-email-k.kozlowski@samsung.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Jul 10 2015 or thereabouts, Krzysztof Kozlowski wrote:
> i2c_driver does not need to set an owner because i2c_register_driver()
> will set it.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> 
> ---

BTW, Dmitry took the same in his tree, so I think we are safe here too.

Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

Cheers,
Benjamin

> 
> The coccinelle script which generated the patch was sent here:
> http://www.spinics.net/lists/kernel/msg2029903.html
> ---
>  drivers/hid/i2c-hid/i2c-hid.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
> index f77469d4edfb..dfd679647391 100644
> --- a/drivers/hid/i2c-hid/i2c-hid.c
> +++ b/drivers/hid/i2c-hid/i2c-hid.c
> @@ -1167,7 +1167,6 @@ MODULE_DEVICE_TABLE(i2c, i2c_hid_id_table);
>  static struct i2c_driver i2c_hid_driver = {
>  	.driver = {
>  		.name	= "i2c_hid",
> -		.owner	= THIS_MODULE,
>  		.pm	= &i2c_hid_pm,
>  		.acpi_match_table = ACPI_PTR(i2c_hid_acpi_match),
>  		.of_match_table = of_match_ptr(i2c_hid_of_match),
> -- 
> 1.9.1
>