* [PATCH] hid: Drop owner assignment from i2c_driver
@ 2015-07-10 5:51 Krzysztof Kozlowski
2015-07-21 17:39 ` Benjamin Tissoires
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2015-07-10 5:51 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires, Mika Westerberg, Antonio Borneo,
Jean-Baptiste Maneyrol, Andrew Duggan, Seth Forshee,
Rafael J. Wysocki, Dan Carpenter, open list:HID CORE LAYER,
open list
Cc: Krzysztof Kozlowski
i2c_driver does not need to set an owner because i2c_register_driver()
will set it.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
The coccinelle script which generated the patch was sent here:
http://www.spinics.net/lists/kernel/msg2029903.html
---
drivers/hid/i2c-hid/i2c-hid.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
index f77469d4edfb..dfd679647391 100644
--- a/drivers/hid/i2c-hid/i2c-hid.c
+++ b/drivers/hid/i2c-hid/i2c-hid.c
@@ -1167,7 +1167,6 @@ MODULE_DEVICE_TABLE(i2c, i2c_hid_id_table);
static struct i2c_driver i2c_hid_driver = {
.driver = {
.name = "i2c_hid",
- .owner = THIS_MODULE,
.pm = &i2c_hid_pm,
.acpi_match_table = ACPI_PTR(i2c_hid_acpi_match),
.of_match_table = of_match_ptr(i2c_hid_of_match),
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] hid: Drop owner assignment from i2c_driver
2015-07-10 5:51 [PATCH] hid: Drop owner assignment from i2c_driver Krzysztof Kozlowski
@ 2015-07-21 17:39 ` Benjamin Tissoires
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Tissoires @ 2015-07-21 17:39 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Jiri Kosina, Mika Westerberg, Antonio Borneo,
Jean-Baptiste Maneyrol, Andrew Duggan, Seth Forshee,
Rafael J. Wysocki, Dan Carpenter, open list:HID CORE LAYER,
open list
On Jul 10 2015 or thereabouts, Krzysztof Kozlowski wrote:
> i2c_driver does not need to set an owner because i2c_register_driver()
> will set it.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> ---
BTW, Dmitry took the same in his tree, so I think we are safe here too.
Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cheers,
Benjamin
>
> The coccinelle script which generated the patch was sent here:
> http://www.spinics.net/lists/kernel/msg2029903.html
> ---
> drivers/hid/i2c-hid/i2c-hid.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
> index f77469d4edfb..dfd679647391 100644
> --- a/drivers/hid/i2c-hid/i2c-hid.c
> +++ b/drivers/hid/i2c-hid/i2c-hid.c
> @@ -1167,7 +1167,6 @@ MODULE_DEVICE_TABLE(i2c, i2c_hid_id_table);
> static struct i2c_driver i2c_hid_driver = {
> .driver = {
> .name = "i2c_hid",
> - .owner = THIS_MODULE,
> .pm = &i2c_hid_pm,
> .acpi_match_table = ACPI_PTR(i2c_hid_acpi_match),
> .of_match_table = of_match_ptr(i2c_hid_of_match),
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-21 17:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-10 5:51 [PATCH] hid: Drop owner assignment from i2c_driver Krzysztof Kozlowski
2015-07-21 17:39 ` Benjamin Tissoires
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox