From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934132AbbGUXx5 (ORCPT ); Tue, 21 Jul 2015 19:53:57 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:42784 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933284AbbGUXx4 (ORCPT ); Tue, 21 Jul 2015 19:53:56 -0400 Date: Tue, 21 Jul 2015 16:53:54 -0700 From: Stephen Boyd To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, Sascha Hauer , Peter De Schrijver , Tero Kristo , Russell King , Dinh Nguyen Subject: Re: [PATCH v5 2/8] clk: mmp: switch to GENMASK() Message-ID: <20150721235354.GB15042@codeaurora.org> References: <1436796468-45723-1-git-send-email-andriy.shevchenko@linux.intel.com> <1436796468-45723-3-git-send-email-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436796468-45723-3-git-send-email-andriy.shevchenko@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/13, Andy Shevchenko wrote: > diff --git a/drivers/clk/mmp/clk.h b/drivers/clk/mmp/clk.h > index adf9b71..f5fdb0e 100644 > --- a/drivers/clk/mmp/clk.h > +++ b/drivers/clk/mmp/clk.h > @@ -39,7 +39,7 @@ extern struct clk *mmp_clk_register_factor(const char *name, > > /* Clock type "mix" */ > #define MMP_CLK_BITS_MASK(width, shift) \ > - (((1 << (width)) - 1) << (shift)) > + (GENMASK((width) - 1, 0) << (shift)) This can push the shift into the GENMASK instance too: (GENMASK((width) - 1 + (shift), (shift)) > #define MMP_CLK_BITS_GET_VAL(data, width, shift) \ > ((data & MMP_CLK_BITS_MASK(width, shift)) >> (shift)) > #define MMP_CLK_BITS_SET_VAL(val, width, shift) \ > -- > 2.1.4 > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project