From: Matt Fleming <matt@codeblueprint.co.uk>
To: "Jonathan (Zhixiong) Zhang" <zjzhang@codeaurora.org>
Cc: Matt Fleming <matt.fleming@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, ying.huang@intel.com, fu.wei@linaro.org,
al.stone@linaro.org, bp@alien8.de, rjw@rjwysocki.net,
catalin.marinas@arm.com, will.deacon@arm.com,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
linaro-acpi@lists.linaro.org
Subject: Re: [PATCH V6 1/4] efi: x86: rearrange efi_mem_attributes()
Date: Wed, 22 Jul 2015 12:11:06 +0100 [thread overview]
Message-ID: <20150722111106.GC2734@codeblueprint.co.uk> (raw)
In-Reply-To: <1437438759-3686-2-git-send-email-zjzhang@codeaurora.org>
On Mon, 20 Jul, at 05:32:36PM, Jonathan (Zhixiong) Zhang wrote:
> From: "Jonathan (Zhixiong) Zhang" <zjzhang@codeaurora.org>
>
> x86 and ia64 implement efi_mem_attributes() differently. This
> function needs to be available for other arch (such as arm64)
> as well, such as for the purpose of ACPI/APEI.
>
> ia64 efi does not setup memmap variable and does not set
> EFI_MEMMAP flag, so it needs to have its unique implementation
> of efi_mem_attributes().
>
> Move efi_mem_attributes() implementation from x86 to efi, and
> declare it with __weak. It is recommended that other archs
> should not override the default implementation.
>
> Signed-off-by: Jonathan (Zhixiong) Zhang <zjzhang@codeaurora.org>
> ---
> arch/x86/platform/efi/efi.c | 18 ------------------
> drivers/firmware/efi/efi.c | 31 +++++++++++++++++++++++++++++++
> 2 files changed, 31 insertions(+), 18 deletions(-)
Reviewed-by: Matt Fleming <matt.fleming@intel.com>
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2015-07-22 11:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 0:32 [PATCH V6 0/4] map GHES memory region according to EFI memory map Jonathan (Zhixiong) Zhang
2015-07-21 0:32 ` [PATCH V6 1/4] efi: x86: rearrange efi_mem_attributes() Jonathan (Zhixiong) Zhang
2015-07-22 11:11 ` Matt Fleming [this message]
2015-07-22 17:21 ` Zhang, Jonathan Zhixiong
2015-07-21 0:32 ` [PATCH V6 2/4] x86: acpi: implement arch_apei_get_mem_attributes() Jonathan (Zhixiong) Zhang
2015-07-22 12:09 ` Matt Fleming
2015-07-22 17:20 ` Zhang, Jonathan Zhixiong
2015-07-21 0:32 ` [PATCH V6 3/4] arm64: apei: " Jonathan (Zhixiong) Zhang
2015-07-21 15:08 ` Will Deacon
2015-07-21 18:23 ` Zhang, Jonathan Zhixiong
2015-07-21 0:32 ` [PATCH V6 4/4] acpi, apei: use appropriate pgprot_t to map GHES memory Jonathan (Zhixiong) Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150722111106.GC2734@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=al.stone@linaro.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=fu.wei@linaro.org \
--cc=hpa@zytor.com \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
--cc=ying.huang@intel.com \
--cc=zjzhang@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).