From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965564AbbGVOQF (ORCPT ); Wed, 22 Jul 2015 10:16:05 -0400 Received: from mail-bn1bon0115.outbound.protection.outlook.com ([157.56.111.115]:31517 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965206AbbGVOQD (ORCPT ); Wed, 22 Jul 2015 10:16:03 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=freescale.com; freescale.mail.onmicrosoft.com; dkim=none (message not signed) header.d=none; Date: Wed, 22 Jul 2015 22:08:10 +0800 From: Dong Aisheng To: CC: Dong Aisheng , , , , , , , , , Subject: Re: [PATCH v2 1/5] clk: remove duplicated code with __clk_set_parent_after Message-ID: <20150722140809.GC13623@shlinux1.ap.freescale.net> References: <1431610143-21853-1-git-send-email-aisheng.dong@freescale.com> <1431610143-21853-2-git-send-email-aisheng.dong@freescale.com> <20150528040919.22384.79189@quantum> <20150715122522.GA30570@shlinux1.ap.freescale.net> <20150715122955.GB30570@shlinux1.ap.freescale.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20150715122955.GB30570@shlinux1.ap.freescale.net> User-Agent: Mutt/1.5.20 (2009-06-14) X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD018;1:F8cZh9qXFNjSO9V+3T1Gpdu+42GT72a+oQ7kqUqRMnnaiUIqOOKrKGfpVoHkerVnewx+aoEm/YzBVpcQhvH4Tmrbfzdt5ziSUJE9H3kHLt76fyul8rRjbCZ/z+L7mJFGGrXHCUn0rXlK0nQrg9ck6G9+boi9VusCfBmdQEQVMgVl4PA0jMkZ7P3bkhN0AZ7DoEnorXJFfbsvp68aT4WA+abiedBzK/mR3fwxBzvomS+8sS+6TxD1u3HQCW8syYsY4n43FafG5UeaN6+n5P9Jkb7Gpsnnc8HDmMiwb+DqeceqEWsEKCyTWGJbPeiepMrxlaAsA39ugH5DPrgTifZeobdWpPSQfiHzLLpuiu0sN/FobKAPdVdng0TY9XEsWuWdpsp0vTv7sQR0OXkNG/iiV+nqhG+0IW/fBU1nbjz+t1T2XqR28Gl2KESWYYC1M8oT X-Forefront-Antispam-Report: CIP:192.88.168.50;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(339900001)(199003)(24454002)(189002)(377424004)(77096005)(50466002)(54356999)(19580395003)(87936001)(50986999)(97756001)(19580405001)(6806004)(62966003)(92566002)(2950100001)(4001350100001)(77156002)(85426001)(33656002)(107886002)(5001960100002)(104016003)(47776003)(46406003)(105606002)(23726002)(110136002)(189998001)(76176999)(83506001)(2351001)(106466001)(5003600100002)(93886004)(46102003)(4001430100001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN3PR03MB1431;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1431;2:/5CuzG2EHoWbeCDlm95U6h1PyXalUmNGGfQGKA0bG7kbW+LJRGmpKvzAsO/koMEF;3:eDGi/t+NYrhv63HODBM9YlsTlZmyisdl1Z3F0/kXBicyq2LVZQg7U4g4k634xy/m/IcUtl6xI8QENAeakV/4wPMgQS4P2T3xJw0Ayo1HNVqhyECYDuDibd/zswXBg4aPkIx8MyU+hdPyTleoZ6tulSshn4LThupq3gZcbkp1XD3XXsoKaFPKJ6T6tsU+eJuHm5AUftb60Ajd0RnoaKf1sc+KMkBKA3L1rLAonvODFxQ=;25:5Rn123iJE10cHBDMkBsT4o1uHy4upGtPBpAIf38dAjs83dX0VNAwwe53HEpcHbz41W8FM6MucSLFJUuYyuYW1Zw9bSa4wtlJ4Nd9IzA8a0KpSBYlyjIrL0gRsMVxuQwRPq8T2Mmn4v4rqZTxu6b+wvWQwzW/dITLNHnrHUsLU3AvvORMFsI7/mZNMw9mogO2DmsOxOKfAasztPWV+naVtiqQHFOKUhLL9gIXJ/kZjZ/HVFqcPF6D/cnR2YAqzNUHjcl8Y2sXzDTvhqolF1hqdA==;20:BbnUXtbKaQj93IvyGSvfBfiHQJ6ezar0h+CLaj/ZKtxQb+T1lwo3h8+DRLYUETT9pJL5TtR2Mo2cJJL5N7MTfFjq1JLZt7zM39RaYMOA0iAPhA2j4La/pAXDkGWDAtvxP1fDARHAiSdk1tDbQZbVj92GPjFY08NlZ8JmiLYgmr/oOIbL+LNDsBZ6tV8s4YQev0oj2cQHsJoIJN6hSuweBKms/a2YqNKPv1BzcED2idxZKFQij46VWzcWf9YUUFV5p5v0RJ3yHx0R2ixy0CmdmxjV9OD+ucRXTYMbs0ajamDRqk+HcQEO3FB9Obp93F9Jq+rAuk9fzMBEhxVDoXR7joylAeHqYGTcsBFRxEVX+Do= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1431;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1414; BN3PR03MB1431: X-MS-Exchange-Organization-RulesExecuted X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BN3PR03MB1431;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1431; X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1431;4:YHM36tlHv3ufe1mz0NY3ZJaOpt4o4pQFHdXvynkum+Vz8rRnLwGCYOUsG3J1QMbaLkBelqzJSEo82mCf1o3ajpB2BOz9pWxwt75ZH51j22boR6hek4TLwTmGbKYoloDX/JRJoIngu2Z3G+krgxj9mZVS6CnSw7frSNPsQ3yBmkVgWOiZ0gWhrBoDlTEJ1PChulDP50vcCQaVgQ9kYs1ARgeaOdcLtYbAHTfKxb+bEyRci1EiYk1aQpO9Jw0JE0Z+Awi5/+YpzCxHsKgoPtIqoqoWQeMQZbHPpSD6cEhoNPg= X-Forefront-PRVS: 0645BEB7AA X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN3PR03MB1431;23:CGFqp8V54v51kqGo+PKrw5o0TGx+Iq9lph60xGQTJ?= =?us-ascii?Q?DKdg/d5vL33Q3884jLDUHeSSnRxnLf6OodcTAs3Y25zbyEfZgaqr5Mn7gJx6?= =?us-ascii?Q?MRW2QG9572ZD6rlBlcPIvYINJ1g1fkQOd63ZtJh2Qbzcr3CfcwrWPDM2aGr7?= =?us-ascii?Q?Llor/QbTNe17k8I/YJsLOuoMploy+UHnJIVMQq/5QHuDQnkCwwcrYMf78+oq?= =?us-ascii?Q?bRIIcgMIoKec/aX+/WYaJrhdPBhSE1lkteUdYQAe60pAlZxWBjVydQLSVbfJ?= =?us-ascii?Q?DYdBHL0T3wGuQb+Hg+S8G5Wzzutd57MuysRs5yJ5TL+JhrnXhw/rqfT7i+Cw?= =?us-ascii?Q?8WtDqJrxeTnxiTrvLiUcUvu2TSVxSiiECdLtuGCdsTcMACXDEqlTzpj4xGe1?= =?us-ascii?Q?kTsWj5LPz1UiYIe64QOQ8AfzE8/HfpiSJPKBNb0VD3tblyH/yBpDJU5zrfl/?= =?us-ascii?Q?2mzmKvGhR5hzQobqDA+/OG48/4gQ8Rq/rHbZPXytZVKjf08oxrEwoUgqIUVZ?= =?us-ascii?Q?USh2U2AdrYDx4cLAnifXAKpckJz1Vdbi8r2K/KrUEOfLxMahlOavpJb5Vp/Y?= =?us-ascii?Q?HnEZgID/sGiE3VZM++Uqy7nHnyaL4q9kmdg8wzzXAJb/CJT+NwyDpF4E+6pf?= =?us-ascii?Q?EAqaImy7UV1i9gEjjB2zBOxH0VtwH51MPxgOGFAgO7ztWnT8kqjfNmcNbZ94?= =?us-ascii?Q?re+hvO2r20VUhVynaF4gWIesROdmiB2t+2GB9InUTJrpEz+4//OL65AeP+5X?= =?us-ascii?Q?s5fAK/JG4ryt/pTLu4Q5S+/CP3M1XOZU6yV9KtprBl+jfKOzAm0mlteSFTJ4?= =?us-ascii?Q?/DHyP3nKJCsx/f4UVamwtxoKbfTBVJUOXCq6S3xvYFgd4OaaHJ4DhVqGJ2wW?= =?us-ascii?Q?O5iFnKoSxPV/rH53U1Zw/lLzLeWUMzHjig8CHGGR453KHpnpBXx8ndyQNbqX?= =?us-ascii?Q?wTiHwwYMwVpWhNWLSpJaMlh//AtQpzIcuc+WY/wntlz53tjFV7TTUq4Q6R9a?= =?us-ascii?Q?ljMRSIJVEKRO+k8wGvzb8TMV6xxwjJzip11RkqUr749DCzHm6l5V5RmjEwXs?= =?us-ascii?Q?wE89TU1Rb3++HJsxezSTCZOG2z8?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1431;5:ILd2ZcpwZwr75Ah97CXsw+IMT5QTlyG83kpk4x/ONEhV5qUcOso6ZOvw/GNN8jCzk+2Le1SWkQ7UMkrfFDfVISv68gLORdFXC8Lp0aPg3XHfvlpi8mYjRWNSKYoedElPwtcZelXwGUiQ2DqcrOPRCg==;24:h/lxXmIc1+BTn65lzmnht0oX7fp1uKsu1UYo0xdhPgXdEPx89Ivg4V+6LT/cmu22Gb2LUEBtLegeOiXwD8QuerkOjCw1ERTbR2eTstE+RDw=;20:OGBHih5PMwXmuMBGX0lRIC4ZSziS9v+eJBhm/UQA4nfc1ZdyDrVU8L3Pkrhz5IMy6nA1P5d/4oplsyITGjFFqA== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2015 14:15:54.0077 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1431 X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1414;2:rth0AiY7TF8O6SX3LTEUwPrZt0KJO5yYLML7RESi5n7M40+zQVHIIetYBmyWyCvJeByp+7tQWAawPiy1qniZyu2QnXokoTRHp7J++um98TT8rcniEMz7C82zFT/nJWzqB6va22vWpj+2MA4RR5O6U5fHUfpJesaOOIp4AEpE6MY=;3:2kKjgVWyNfwSnoyRoSwocjJrjeaSNNtYfRmEyXEuuPFGBsd+zG7baMwQJMVJ1n15SeSEHhJj7lrf7Mt9GQyNBXH9/7AYqn4vaQiN8PEzTgVLFAhu4Ih+pgx4bb2mH0vyF8+k9B+FwZHBooiPZZgWON1sI1TUYt3LMWfaJNMFvhUImWzwl4T8s2DGCgDumNQvg4JBGQu2zkN0ChqBdLqAN5HcdyUQAd1TO5yVQdiD1Wc=;25:46UGrOG1MA0hGIV75Pvo82+ZmXxUVfJcisVS0FcUFDP+O3bueDY6kefePJIN9mBy6MzCzlyUXWcZa3FEvFUK/x9X5VfLdPEgCsUJ83dmfcCCSR7pRB59zr4zJ11FIn9+IgAHXM9ZP8iqctm5WBwF7l7VFT4Q5leWIoAG9YeysUFuawATxVa9pedlgykEUdPfWHppc12CSd/iPOtFHmro8KRROx8zPJouvnlsxDWQhael7A/rMZNgsOUaH6mEklFuQv8PzPMV+IpzXTmO0qL6TQ==;23:Zy+FLFcaOZcU/sgEcRtOv+s+roBbEQ194jDOT0CQouReXnKe+EUVV18HEIdQg8NsSTdEHkDqFQBwsBKzfXrk4EdnNxKjOMRXUS7K1Lg5skKJvxcFDb/HEgWYFMW1SM799PaC/8R09KmlcFrwQ19JU2yWqFGMQHRSNHeAqOi63KNBcoHp/V2yL3hJMRKsHy76IYWWy4qJeRfPPsd/FfzY7AjWwK6xq5xb+1MO2T9nCn2yzm98taeD4rTeJCgGpcjd X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ping... On Wed, Jul 15, 2015 at 08:29:56PM +0800, Dong Aisheng wrote: > On Wed, Jul 15, 2015 at 08:25:24PM +0800, Dong Aisheng wrote: > > Hi Mike, > > > > On Wed, May 27, 2015 at 09:09:19PM -0700, Michael Turquette wrote: > > > Quoting Dong Aisheng (2015-05-14 06:28:59) > > > > __clk_set_parent_after() actually used the second argument then we > > > > could put this duplicate logic in there and call it with a different > > > > order of arguments in the success vs. error paths in this function. > > > > > > > > Cc: Mike Turquette > > > > Cc: Stephen Boyd > > > > Suggested-by: Stephen Boyd > > > > Signed-off-by: Dong Aisheng > > > > > > Patch looks good to me. > > > > > > Also just noticed that the second argument to __clk_set_parent_after is > > > never used :-( > > > > > > > Ping... > > > > I did not see this patch series in your tree for v4.2 rc. > > Is this got missed? > > > > Updated Mike's email address. > > Regards > Dong Aisheng > > > Regards > > Dong Aisheng > > > > > Regards, > > > Mike > > > > > > > --- > > > > drivers/clk/clk.c | 8 +------- > > > > 1 file changed, 1 insertion(+), 7 deletions(-) > > > > > > > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > > > > index 659f2b0..0e813ea 100644 > > > > --- a/drivers/clk/clk.c > > > > +++ b/drivers/clk/clk.c > > > > @@ -1159,14 +1159,8 @@ static int __clk_set_parent(struct clk_core *core, struct clk_core *parent, > > > > flags = clk_enable_lock(); > > > > clk_reparent(core, old_parent); > > > > clk_enable_unlock(flags); > > > > + __clk_set_parent_after(core, old_parent, parent); > > > > > > > > - if (core->prepare_count) { > > > > - flags = clk_enable_lock(); > > > > - clk_core_disable(core); > > > > - clk_core_disable(parent); > > > > - clk_enable_unlock(flags); > > > > - clk_core_unprepare(parent); > > > > - } > > > > return ret; > > > > } > > > > > > > > -- > > > > 1.9.1 > > > >