From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752242AbbGVUdG (ORCPT ); Wed, 22 Jul 2015 16:33:06 -0400 Received: from down.free-electrons.com ([37.187.137.238]:37375 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750779AbbGVUdF (ORCPT ); Wed, 22 Jul 2015 16:33:05 -0400 Date: Wed, 22 Jul 2015 22:32:59 +0200 From: Alexandre Belloni To: Dmitry Torokhov Cc: Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Vasiliy Kulikov Subject: Re: [PATCH 1/4] RTC: fix double free in rtc_register_device() error path Message-ID: <20150722203259.GL2853@piout.net> References: <1437433372-15425-1-git-send-email-dmitry.torokhov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437433372-15425-1-git-send-email-dmitry.torokhov@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/07/2015 at 16:02:49 -0700, Dmitry Torokhov wrote : > Commit 59cca865f21e9e7beab73fcf79ba4eb776a4c228 correctly noted that naked > kfree() should not be used after failed device_register() call, however, > while it added the needed put_device() it forgot to remove the original > kfree() causing double-free. > > Cc: Vasiliy Kulikov > Signed-off-by: Dmitry Torokhov > --- > drivers/rtc/class.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) Applied after fixing the commit description in the commit log, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com