From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] RTC: properly manage lifetime of dev and cdev in rtc device
Date: Wed, 22 Jul 2015 22:40:57 +0200 [thread overview]
Message-ID: <20150722204057.GN2853@piout.net> (raw)
In-Reply-To: <1437433372-15425-3-git-send-email-dmitry.torokhov@gmail.com>
On 20/07/2015 at 16:02:51 -0700, Dmitry Torokhov wrote :
> struct rtc embeds both struct dev and struct cdev. Unfortunately character
> device structure may outlive the parent rtc structure unless we set it up
> as parent of character device so that it will stay pinned until character
> device is freed.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/rtc/rtc-dev.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-07-22 20:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 23:02 [PATCH 1/4] RTC: fix double free in rtc_register_device() error path Dmitry Torokhov
2015-07-20 23:02 ` [PATCH 2/4] RTC: remove unnecessary device_get() in rtc_device_unregister Dmitry Torokhov
2015-07-21 0:39 ` [rtc-linux] " Krzysztof Kozlowski
2015-07-22 20:33 ` Alexandre Belloni
2015-07-20 23:02 ` [PATCH 3/4] RTC: properly manage lifetime of dev and cdev in rtc device Dmitry Torokhov
2015-07-21 0:54 ` [rtc-linux] " Krzysztof Kozlowski
2015-07-22 20:40 ` Alexandre Belloni [this message]
2015-07-20 23:02 ` [PATCH 4/4] RTC: switch to using is_visible() to control sysfs attributes Dmitry Torokhov
2015-07-21 1:21 ` [rtc-linux] " Krzysztof Kozlowski
2015-07-22 20:57 ` Alexandre Belloni
2015-07-22 21:44 ` Dmitry Torokhov
2015-07-23 0:40 ` Krzysztof Kozlowski
2015-07-22 20:53 ` Alexandre Belloni
2015-07-21 0:32 ` [rtc-linux] [PATCH 1/4] RTC: fix double free in rtc_register_device() error path Krzysztof Kozlowski
2015-07-21 0:42 ` Dmitry Torokhov
2015-07-22 20:32 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150722204057.GN2853@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox