From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752692AbbGVUx4 (ORCPT ); Wed, 22 Jul 2015 16:53:56 -0400 Received: from down.free-electrons.com ([37.187.137.238]:38001 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752389AbbGVUxy (ORCPT ); Wed, 22 Jul 2015 16:53:54 -0400 Date: Wed, 22 Jul 2015 22:53:52 +0200 From: Alexandre Belloni To: Dmitry Torokhov Cc: Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] RTC: switch to using is_visible() to control sysfs attributes Message-ID: <20150722205352.GO2853@piout.net> References: <1437433372-15425-1-git-send-email-dmitry.torokhov@gmail.com> <1437433372-15425-4-git-send-email-dmitry.torokhov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437433372-15425-4-git-send-email-dmitry.torokhov@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Seems mostly good, a few comments on top of Krzysztof's below: On 20/07/2015 at 16:02:52 -0700, Dmitry Torokhov wrote : > Instead of creating an attribute manually, after the device has been > registered, let's rely on facilities provided by the attribute groups to > control which attributes are visible and which are not. This allows to to too many 'to' here --------------------------------------------------^ [...] > -void __init rtc_sysfs_init(struct class *rtc_class) > +const struct attribute_group** rtc_get_dev_attribute_groups(void) That space is not properly placed ^, this should be: const struct attribute_group **rtc_get_dev_attribute_groups(void) -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com