From: Christoph Hellwig <hch@infradead.org>
To: Spencer Baugh <sbaugh@catern.com>
Cc: "Nicholas A. Bellinger" <nab@linux-iscsi.org>,
"open list:TARGET SUBSYSTEM" <linux-scsi@vger.kernel.org>,
"open list:TARGET SUBSYSTEM" <target-devel@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Joern Engel <joern@purestorage.com>,
Spencer Baugh <Spencer.baugh@purestorage.com>,
Roland Dreier <roland@purestorage.com>
Subject: Re: [PATCH] target: respond to unknown initiators with sensible REPORT LUNS list length
Date: Thu, 23 Jul 2015 02:41:09 -0700 [thread overview]
Message-ID: <20150723094109.GF5382@infradead.org> (raw)
In-Reply-To: <1437602898-15229-3-git-send-email-sbaugh@catern.com>
On Wed, Jul 22, 2015 at 03:08:17PM -0700, Spencer Baugh wrote:
> done:
> + /*
> + * If no real LUNs are accessible, report an allocation length
> + * of 1 LUN to account for virtual LUN 0.
> + */
> + if (lun_count == 0)
> + lun_count = 1;
> +
Shouldn't the code actually report the virtual lun zero instead of just
accounting for it?
prev parent reply other threads:[~2015-07-23 9:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 22:08 [PATCH] target: respond to unknown initiators with sensible REPORT LUNS list length Spencer Baugh
2015-07-23 9:41 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150723094109.GF5382@infradead.org \
--to=hch@infradead.org \
--cc=Spencer.baugh@purestorage.com \
--cc=joern@purestorage.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=roland@purestorage.com \
--cc=sbaugh@catern.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox