The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ioan-Adrian Ratiu <adi@adirat.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	mateusz.kulikowski@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192e: rtllib: fix macro style issue
Date: Thu, 23 Jul 2015 15:15:24 +0300	[thread overview]
Message-ID: <20150723121524.GT5371@mwanda> (raw)
In-Reply-To: <1437649173-24280-1-git-send-email-adi@adirat.com>

On Thu, Jul 23, 2015 at 01:59:33PM +0300, Ioan-Adrian Ratiu wrote:
> Enclose defined macro in paranthesis to avoid checkpatch complaint
> "ERROR: Macros with complex values should be enclosed in parentheses"
> 
> Signed-off-by: Ioan-Adrian Ratiu <adi@adirat.com>
> ---
>  drivers/staging/rtl8192e/rtllib_rx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
> index 54dfff6..5f1650c 100644
> --- a/drivers/staging/rtl8192e/rtllib_rx.c
> +++ b/drivers/staging/rtl8192e/rtllib_rx.c
> @@ -1744,7 +1744,7 @@ static int rtllib_parse_qos_info_param_IE(struct rtllib_device *ieee,
>  	return rc;
>  }
>  
> -#define MFIE_STRING(x) case MFIE_TYPE_ ##x: return #x
> +#define MFIE_STRING(x) (case MFIE_TYPE_ ##x: return #x)
>  

This will break the build.  Be more careful.

regards,
dan carpenter


  reply	other threads:[~2015-07-23 12:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-23 10:59 [PATCH] staging: rtl8192e: rtllib: fix macro style issue Ioan-Adrian Ratiu
2015-07-23 12:15 ` Dan Carpenter [this message]
2015-07-23 13:24 ` [PATCH v2] " Ioan-Adrian Ratiu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150723121524.GT5371@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=adi@adirat.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mateusz.kulikowski@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox