From: Lee Jones <lee.jones@linaro.org>
To: Chris Zhong <zyw@rock-chips.com>
Cc: broonie@kernel.org, heiko@sntech.de, dianders@chromium.org,
linux-rockchip@lists.infradead.org, sonnyrao@chromium.org,
amstan@google.com, mark.rutland@arm.com,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Zhang Qing <zhangqing@rock-chips.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] mfd: dt-bindings: add the description about dvs gpio for rk808
Date: Thu, 23 Jul 2015 15:49:15 +0100 [thread overview]
Message-ID: <20150723144915.GH3436@x1> (raw)
In-Reply-To: <1437384233-26169-2-git-send-email-zyw@rock-chips.com>
On Mon, 20 Jul 2015, Chris Zhong wrote:
> add the description about dvs1, dvs2, and add the example.
>
> Signed-off-by: Chris Zhong <zyw@rock-chips.com>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
>
> ---
>
> Changes in v4:
> - Remove the description about dvs-ok
>
> Changes in v3:
> - Modify the syntax error
>
> Changes in v2:
> - increase description about dvs pins
>
> Documentation/devicetree/bindings/mfd/rk808.txt | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
Applied, thanks.
> diff --git a/Documentation/devicetree/bindings/mfd/rk808.txt b/Documentation/devicetree/bindings/mfd/rk808.txt
> index 9e6e259..4ca6aab 100644
> --- a/Documentation/devicetree/bindings/mfd/rk808.txt
> +++ b/Documentation/devicetree/bindings/mfd/rk808.txt
> @@ -24,6 +24,10 @@ Optional properties:
> - vcc10-supply: The input supply for LDO_REG6
> - vcc11-supply: The input supply for LDO_REG8
> - vcc12-supply: The input supply for SWITCH_REG2
> +- dvs-gpios: buck1/2 can be controlled by gpio dvs, this is GPIO specifiers
> + for 2 host gpio's used for dvs. The format of the gpio specifier depends in
> + the gpio controller. If DVS GPIOs aren't present, voltage changes will happen
> + very quickly with no slow ramp time.
>
> Regulators: All the regulators of RK808 to be instantiated shall be
> listed in a child node named 'regulators'. Each regulator is represented
> @@ -55,7 +59,9 @@ Example:
> interrupt-parent = <&gpio0>;
> interrupts = <4 IRQ_TYPE_LEVEL_LOW>;
> pinctrl-names = "default";
> - pinctrl-0 = <&pmic_int>;
> + pinctrl-0 = <&pmic_int &dvs_1 &dvs_2>;
> + dvs-gpios = <&gpio7 11 GPIO_ACTIVE_HIGH>,
> + <&gpio7 15 GPIO_ACTIVE_HIGH>;
> reg = <0x1b>;
> rockchip,system-power-controller;
> wakeup-source;
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-07-23 14:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 9:23 [PATCH v4 0/2] fixed the overshoot when adjust voltage Chris Zhong
2015-07-20 9:23 ` [PATCH v4 1/2] mfd: dt-bindings: add the description about dvs gpio for rk808 Chris Zhong
2015-07-20 17:52 ` Applied "regulator: rk808: add the description about dvs gpio for rk808" to the regulator tree Mark Brown
2015-07-23 14:49 ` Lee Jones [this message]
2015-07-20 9:23 ` [PATCH v4 2/2] regulator: rk808: fixed the overshoot when adjust voltage Chris Zhong
2015-07-20 17:52 ` Applied "regulator: rk808: fixed the overshoot when adjust voltage" to the regulator tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150723144915.GH3436@x1 \
--to=lee.jones@linaro.org \
--cc=amstan@google.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sonnyrao@chromium.org \
--cc=zhangqing@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox