From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752966AbbGWPRD (ORCPT ); Thu, 23 Jul 2015 11:17:03 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:36964 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752389AbbGWPQ5 (ORCPT ); Thu, 23 Jul 2015 11:16:57 -0400 Date: Thu, 23 Jul 2015 16:16:52 +0100 From: Lee Jones To: Javier Martinez Canillas Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Sergei Shtylyov , Mark Brown , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 3/4] mfd: Add DT binding for Maxim MAX77802 IC Message-ID: <20150723151652.GK3436@x1> References: <1437114567-17629-1-git-send-email-javier@osg.samsung.com> <1437114567-17629-4-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1437114567-17629-4-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 17 Jul 2015, Javier Martinez Canillas wrote: > The MAX77802 is a chip that contains regulators, 2 32kHz clocks, > a RTC and an I2C interface to program the individual components. > > The are already DT bindings for the regulators and clocks and > these reference to a bindings/mfd/max77802.txt file, that didn't > exist, for the details about the PMIC. > > Signed-off-by: Javier Martinez Canillas > > --- > > Changes in v2: > - Use the correct "maxim,max77802" compatible string. > Suggested by Krzysztof Kozlowski > - Use a pmic generic node name for the max77802 node example. > Suggested by Sergei Shtylyov. > > Documentation/devicetree/bindings/mfd/max77802.txt | 26 ++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/max77802.txt > > diff --git a/Documentation/devicetree/bindings/mfd/max77802.txt b/Documentation/devicetree/bindings/mfd/max77802.txt > new file mode 100644 > index 000000000000..c60cdec50d36 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/max77802.txt > @@ -0,0 +1,26 @@ > +Maxim MAX77802 multi-function device > + > +The Maxim MAX77802 is a power management chip (PMIC) that contains 10 high > +efficiency Buck regulators, 32 Low-dropout (LDO) regulators used to power Would be good to capitalise the works in the acronyms, so "Low-DropOut" and "Power Management IC". > +up application processors and peripherals, a 2-channel 32kHz clock outputs, > +a Real-Time-Clock (RTC) and a I2C interface to program the individual > +regulators, clocks outputs and the RTC. > + > +Binding for the built-in 32k clock generator block is defined separately > +in the bindings/clk/maxim,max77802.txt file and binding for the regulators s/bindings/../ > +is defined in the bindings/regulator/max77802.txt file. > + > +Required properties: > +- compatible : Must be "maxim,max77802"; > +- reg : Specifies the i2c slave address of PMIC block. s/i2c/I2C/ > +- interrupts : This i2c device has an IRQ line connected to the main SoC. As above. > +- interrupt-parent : The parent interrupt controller. > + > +Example: > + > + max77802: pmic@09 { > + compatible = "maxim,max77802"; > + interrupt-parent = <&intc>; > + interrupts = <26 0>; Is there a define in include/dt-bindings/interrupt-controller to replace 0? IRQ_TYPE_NONE perhaps. > + reg = <0x09>; > + }; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog