From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753513AbbGWPl5 (ORCPT ); Thu, 23 Jul 2015 11:41:57 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:36240 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753207AbbGWPlt (ORCPT ); Thu, 23 Jul 2015 11:41:49 -0400 Date: Thu, 23 Jul 2015 16:41:45 +0100 From: Lee Jones To: Linus Walleij Cc: Samuel Ortiz , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] mfd: ipaq-micro: convert prints to debug prints Message-ID: <20150723154145.GQ3436@x1> References: <1437551743-20599-1-git-send-email-linus.walleij@linaro.org> <1437551743-20599-2-git-send-email-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1437551743-20599-2-git-send-email-linus.walleij@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 22 Jul 2015, Linus Walleij wrote: > There is a special function for debug prints rather than the > usual hexdump function, let's use it. > > Signed-off-by: Linus Walleij > --- > drivers/mfd/ipaq-micro.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/ipaq-micro.c b/drivers/mfd/ipaq-micro.c > index 99bc2e844c29..9bfe2462c5c5 100644 > --- a/drivers/mfd/ipaq-micro.c > +++ b/drivers/mfd/ipaq-micro.c > @@ -53,8 +53,8 @@ static void ipaq_micro_trigger_tx(struct ipaq_micro *micro) > tx->buf[bp++] = checksum; > tx->len = bp; > tx->index = 0; > - print_hex_dump(KERN_DEBUG, "data: ", DUMP_PREFIX_OFFSET, 16, 1, > - tx->buf, tx->len, true); > + print_hex_dump_debug("data: ", DUMP_PREFIX_OFFSET, 16, 1, > + tx->buf, tx->len, true); > > /* Enable interrupt */ > val = readl(micro->base + UTCR3); > @@ -281,8 +281,8 @@ static void ipaq_micro_eeprom_dump(struct ipaq_micro *micro) > dev_info(micro->dev, "RAM size: %u KiB\n", ipaq_micro_to_u16(dump+92)); > dev_info(micro->dev, "screen: %u x %u\n", > ipaq_micro_to_u16(dump+94), ipaq_micro_to_u16(dump+96)); > - print_hex_dump(KERN_DEBUG, "eeprom: ", DUMP_PREFIX_OFFSET, 16, 1, > - dump, 256, true); > + print_hex_dump_debug("eeprom: ", DUMP_PREFIX_OFFSET, 16, 1, > + dump, 256, true); > > } > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog