From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754031AbbGWP6c (ORCPT ); Thu, 23 Jul 2015 11:58:32 -0400 Received: from e38.co.us.ibm.com ([32.97.110.159]:55377 "EHLO e38.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753410AbbGWP6W (ORCPT ); Thu, 23 Jul 2015 11:58:22 -0400 X-Helo: d03dlp01.boulder.ibm.com X-MailFrom: paulmck@linux.vnet.ibm.com X-RcptTo: linux-kernel@vger.kernel.org Date: Thu, 23 Jul 2015 08:58:17 -0700 From: "Paul E. McKenney" To: Borislav Petkov Cc: X86-ML , Tony Luck , Aravind Gopalakrishnan , LKML , Linux EDAC Subject: Re: [RFC PATCH 2/4] x86/mce: Rename rcu_dereference_check_mce() to mce_log_get_idx_check() Message-ID: <20150723155816.GY3717@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <1437554428-24788-1-git-send-email-bp@alien8.de> <1437554428-24788-3-git-send-email-bp@alien8.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437554428-24788-3-git-send-email-bp@alien8.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15072315-0029-0000-0000-00000B75EE45 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 22, 2015 at 10:40:26AM +0200, Borislav Petkov wrote: > From: Borislav Petkov > > The "rcu_" prefix misleads for it being a proper RCU interface which > is not. It basically checks whether we're preemptible or holding the > chrdev_read mutex. > > Rename it accordingly. > > Signed-off-by: Borislav Petkov > Cc: "Paul E. McKenney" Acked-by: Paul E. McKenney > --- > arch/x86/kernel/cpu/mcheck/mce.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c > index 5a19adb86b8f..36c065e6fa94 100644 > --- a/arch/x86/kernel/cpu/mcheck/mce.c > +++ b/arch/x86/kernel/cpu/mcheck/mce.c > @@ -52,11 +52,11 @@ > > static DEFINE_MUTEX(mce_chrdev_read_mutex); > > -#define rcu_dereference_check_mce(p) \ > +#define mce_log_get_idx_check(p) \ > ({ \ > rcu_lockdep_assert(rcu_read_lock_sched_held() || \ > lockdep_is_held(&mce_chrdev_read_mutex), \ > - "suspicious rcu_dereference_check_mce() usage"); \ > + "suspicious mce_log_get_idx_check() usage"); \ > smp_load_acquire(&(p)); \ > }) > > @@ -165,7 +165,7 @@ void mce_log(struct mce *mce) > mce->finished = 0; > wmb(); > for (;;) { > - entry = rcu_dereference_check_mce(mcelog.next); > + entry = mce_log_get_idx_check(mcelog.next); > for (;;) { > > /* > @@ -1812,7 +1812,7 @@ static ssize_t mce_chrdev_read(struct file *filp, char __user *ubuf, > goto out; > } > > - next = rcu_dereference_check_mce(mcelog.next); > + next = mce_log_get_idx_check(mcelog.next); > > /* Only supports full reads right now */ > err = -EINVAL; > -- > 2.5.0.rc2.28.g6003e7f > >