Re: [PATCH 0/8] Add support for additional bq27xxx devices

Andreas Dannenberg
2015-07-23T17:02:03Z

On 07/23/2015 11:27 AM, Pali Rohár wrote:
> On Wednesday 22 July 2015 16:51:52 Andrew F. Davis wrote:

<snip>

> And I have another question for you: I see that there are now more
> bq24*_charger.c drivers for TI BQ charger chips. Do you think if it is
> possible to do some cleanup & merge? Or all those charger chips
> different and every one should live in own kernel module?

Pali,
on a related note I recently started working on a new driver named
bq242xx_charger.c that will add support for the following devices:

bq24250
bq24251
bq24261M
bq24262

These are TI's key devices in the bq2425x and bq2426x sub-families. I was
actually also thinking about some larger consolidation but was
concerned about touching/breaking existing stuff and decided to do one
step at a time. And yes while there is some system-level overlap between
most bq24xxx I'm also worried that providing good coverage of all
important device features for all different bq24xxx devices would yield
a very large and hard to understand driver.

As part of the bq242xx_charger.c development I'm keeping a close eye on
the existing bq24xxx drivers. If there seems an elegant way to do some
consolidation after all I might be able to broaden the scope of my work.

This being said I welcome additional ideas/suggestions here but for this
we should probably start a new thread.

Regards,

--
Andreas Dannenberg
Texas Instruments Inc.