Re: [PATCH 5/8] power: bq27x00_battery: Renaming for consistency

Pali Rohár
2015-07-23T20:15:41Z

[-- Attachment #1: Type: Text/Plain, Size: 1172 bytes --]

On Thursday 23 July 2015 19:03:08 Andrew F. Davis wrote:
> >> -#ifdef CONFIG_BATTERY_BQ27X00_I2C
> >> -MODULE_ALIAS("i2c:bq27000-battery");
> >> +#ifdef CONFIG_BATTERY_BQ27XXX_I2C
> >> +MODULE_ALIAS("i2c:bq27xxx-battery");
> >>
> >> #endif
> >
> > Why is this MODULE_ALIAS needed? Some lines upper there is
> >
> > MODULE_DEVICE_TABLE(i2c, bq27xxx_id);
> >
> > which add proper i2c: module alias...
>
> Not sure, looks like it was added in commit
> 8ebb7e9c1a502cfc300618c19c3c6f06fc76d237 which claims that the
> "module won't get loaded automatically" without it, but I have not
> had this problem, so I'm not sure why it's there.
>

git grep bq27000-battery show me that only one driver uses that name:
drivers/w1/slaves/w1_bq27000.c

And more over, it is platform device, not i2c device. So that commit
8ebb7e9c1a502cfc300618c19c3c6f06fc76d237 is wrong! CCing Marek.

MODULE_ALIAS("platform:bq27000-battery") is really needed for
w1_bq27000.c but MODULE_ALIAS("i2c:bq27000-battery") should be removed.
It is not used by any board platform code or DT.

Marek, correct me if I'm wrong.

--
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]