Re: [PATCH 8/8] power: bq27xxx_battery: Cleanup health checking

Joe Perches
2015-07-23T17:06:44Z

On Thu, 2015-07-23 at 18:22 +0200, Pali Rohár wrote:
> On Wednesday 22 July 2015 16:52:00 Andrew F. Davis wrote:
> > Reorganize the logic checking battery health and under temperature
> > condition checking.
[]
> > diff --git a/drivers/power/bq27xxx_battery.c b/drivers/power/bq27xxx_battery.c
[]
> > @@ -624,10 +626,34 @@ static int bq27xxx_battery_read_pwr_avg(struct bq27xxx_device_info *di)
> > */
> > static int bq27xxx_battery_overtemp(struct bq27xxx_device_info *di, u16 flags)
> > {
> > - if (di->chip == BQ27500 || di->chip == BQ27541)
> > + if (di->chip == BQ27500 || di->chip == BQ27541 || di->chip == BQ27545)
> > return flags & (BQ27XXX_FLAG_OTC | BQ27XXX_FLAG_OTD);
> > + if (di->chip == BQ27530 || di->chip == BQ27421)
> > + return flags & BQ27XXX_FLAG_OT;
> > +
> > + return false;

Maybe this int function should be bool or return 0
instead of false.

> > +static int bq27xxx_battery_undertemp(struct bq27xxx_device_info *di, u16 flags)
> > +{
> > + if (di->chip == BQ27530 || di->chip == BQ27421)
> > + return flags & BQ27XXX_FLAG_UT;
> > +
> > + return false;
> > +}

Here too

> > +
> > +/*
> > + * Returns true if a low state of charge condition is detected
> > + */
> > +static int bq27xxx_battery_dead(struct bq27xxx_device_info *di, u16 flags)
> > +{
> > + if (di->chip == BQ27000 || di->chip == BQ27010)
> > + return flags & (BQ27000_FLAG_EDV1 | BQ27000_FLAG_EDVF);
> > else
> > - return flags & BQ27XXX_FLAG_OTC;
> > + return flags & (BQ27XXX_FLAG_SOC1 | BQ27XXX_FLAG_SOCF);
> > }

and here