Re: [RFC PATCH] tools lib traceevent: Allow setting an alternative symbol resolver

[Arnaldo Carvalho de Melo <acme@kernel.org>]

Em Thu, Jul 23, 2015 at 02:11:33PM -0400, Steven Rostedt escreveu:
> On Thu, 23 Jul 2015 14:10:39 -0400 Steven Rostedt <rostedt@goodmis.org> wrote:
> > On Thu, 23 Jul 2015 14:25:54 -0300
> > Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > > diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
> > > +static struct {
> > > +	pevent_function_resolver_t *function;
> > > +	void 			   *priv;
> > > +} function_resolver;
> > > +
> > > +/**
> > > + * pevent_set_function_resolver - set an alternative function resolver
> > > + * @resolver - function to be used
> > > + * @priv - resolver function private state.
> > > + *
> > > + * Some tools may have already a way to resolve kernel functions, allow them
> > > + * to keep using it instead of duplicating all the entries inside pevent->funclist.
> > > + */
> > > +void pevent_set_function_resolver(pevent_function_resolver_t *resolver, void *priv)
> > > +{
> > > +	function_resolver.function = resolver;
> > > +	function_resolver.priv	  = priv;
> > 
> > What about passing in pevent, and making the allocation here?
> 
> In fact, we could remove the global function_resolver, and allocate
> that here too.

Ok, I'll do it, something else?

- Arnaldo