public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Incarnation P. Lee" <incarnation.p.lee@outlook.com>
Cc: oleg.drokin@intel.com, andreas.dilger@intel.com,
	Julia.Lawall@lip6.fr, HPDD-discuss@ml01.01.org,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] Add blank line under variable declaration.
Date: Thu, 23 Jul 2015 14:54:22 -0700	[thread overview]
Message-ID: <20150723215422.GB32146@kroah.com> (raw)
In-Reply-To: <BLU437-SMTP62081409E6F39CC446B703A4820@phx.gbl>

For all of these, you need a better subject line that shows what part of
the kernel you are modifying.

For example, this one would be:
	Subject: [PATCH 1/5] staging: lustre: cl_page.c: add blank line after variable definition


On Thu, Jul 23, 2015 at 02:21:10PM +0800, Incarnation P. Lee wrote:
> Signed-off-by: Incarnation P. Lee <incarnation.p.lee@outlook.com>
> 

We need a changelog entry, it can't be blank.

And I need a hint of "real" name here, is "Incarnation P. Lee" how you
sign legal documents?

thanks,

greg k-h

  reply	other threads:[~2015-07-23 21:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <pli28>
2015-07-23  6:20 ` Fix one source file coding sytle issue Incarnation P. Lee
2015-07-23 14:45   ` Frans Klaver
2015-07-23  6:21 ` [PATCH 1/5] Add blank line under variable declaration Incarnation P. Lee
2015-07-23 21:54   ` Greg KH [this message]
2015-07-23  6:21 ` [PATCH 2/5] Add one space after that ',' in parameters list Incarnation P. Lee
2015-07-23  6:22 ` [PATCH 3/5] Remove unnecessary braces {} are for single statement blocks Incarnation P. Lee
2015-07-23  6:22 ` [PATCH 4/5] Replace spaces at the start of a line with tab Incarnation P. Lee
2015-07-23  6:23 ` [PATCH 5/5] Adjust code indent for conditional statements " Incarnation P. Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150723215422.GB32146@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=HPDD-discuss@ml01.01.org \
    --cc=Julia.Lawall@lip6.fr \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=incarnation.p.lee@outlook.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox