From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754480AbbGWVyZ (ORCPT ); Thu, 23 Jul 2015 17:54:25 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45105 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753979AbbGWVyW (ORCPT ); Thu, 23 Jul 2015 17:54:22 -0400 Date: Thu, 23 Jul 2015 14:54:22 -0700 From: Greg KH To: "Incarnation P. Lee" Cc: oleg.drokin@intel.com, andreas.dilger@intel.com, Julia.Lawall@lip6.fr, HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] Add blank line under variable declaration. Message-ID: <20150723215422.GB32146@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org For all of these, you need a better subject line that shows what part of the kernel you are modifying. For example, this one would be: Subject: [PATCH 1/5] staging: lustre: cl_page.c: add blank line after variable definition On Thu, Jul 23, 2015 at 02:21:10PM +0800, Incarnation P. Lee wrote: > Signed-off-by: Incarnation P. Lee > We need a changelog entry, it can't be blank. And I need a hint of "real" name here, is "Incarnation P. Lee" how you sign legal documents? thanks, greg k-h