From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752057AbbGXEFu (ORCPT ); Fri, 24 Jul 2015 00:05:50 -0400 Received: from mail-by2on0148.outbound.protection.outlook.com ([207.46.100.148]:43760 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750778AbbGXEFq (ORCPT ); Fri, 24 Jul 2015 00:05:46 -0400 X-Greylist: delayed 1121 seconds by postgrey-1.27 at vger.kernel.org; Fri, 24 Jul 2015 00:05:46 EDT Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=freescale.com; freescale.mail.onmicrosoft.com; dkim=none (message not signed) header.d=none; Date: Fri, 24 Jul 2015 11:23:07 +0800 From: Dong Aisheng To: Michael Turquette CC: Dong Aisheng , , , , , , , , , Subject: Re: [PATCH v2 1/5] clk: remove duplicated code with __clk_set_parent_after Message-ID: <20150724032304.GA16916@shlinux1.ap.freescale.net> References: <1431610143-21853-1-git-send-email-aisheng.dong@freescale.com> <1431610143-21853-2-git-send-email-aisheng.dong@freescale.com> <20150528040919.22384.79189@quantum> <20150715122522.GA30570@shlinux1.ap.freescale.net> <20150715122955.GB30570@shlinux1.ap.freescale.net> <20150722140809.GC13623@shlinux1.ap.freescale.net> <20150724001135.642.54711@quantum> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20150724001135.642.54711@quantum> User-Agent: Mutt/1.5.20 (2009-06-14) X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD037;1:dZ/RhOYyS95B4OPCLWxZhd1HbH3PxTyom7E1ai/bt/u7uVDLY6NZX9iKGR0IDG/50CQ/6TEUSOUX60zBGdBicVm0XSlQXbI/1eoZsqgMPh18TaInYU35o4w6hipOB55JBeHFWmz9BxCU+O8SMMkzEGF8yiOocj2cZZ5hFcKvXYI2hObe0USSD1kk8DIxdKHUbILeEYKrhAbbf6PZRi0XhqN8kbQD+GrQ+PWCG0dF8acJKZMOLgG0x+ccpcxwjutQOgtQC+jg5mKydeVTA/pSBte299Eeaa9gLwVNyDxFi/qdzg9ok4v45w4YgqGTxE4ZqySASk63HThBqacdwMpzRylAcEwOjQJPswLyZux3S2zgYpz+5CJGld6TBpSxfho00aLpoYAr6ELsjsN9dB2O6sevLn4qd05DaM9sSYTm0fn0eThGca7Nv4TCt+84aG0l X-Forefront-Antispam-Report: CIP:192.88.158.2;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(339900001)(24454002)(189002)(199003)(377424004)(164054003)(77096005)(85426001)(4001350100001)(189998001)(87936001)(107886002)(46406003)(5001960100002)(110136002)(50466002)(19580405001)(46102003)(19580395003)(47776003)(104016003)(77156002)(23726002)(83506001)(105606002)(50986999)(6806004)(97756001)(62966003)(92566002)(106466001)(15975445007)(54356999)(76176999)(5003600100002)(93886004)(33656002)(2950100001)(4001430100001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0301MB1641;H:az84smr01.freescale.net;FPR:;SPF:Fail;MLV:sfv;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1641;2:79WZ3jzqA1HDUWUVOcFvitrTWjLEVhsvq4rm6qcgsHx7mMlSTrRdP7PHLAWXCR7ShUbbyAAjbIph+RXjkBRo8E0ndrwwXhKOoIKcMs1ZZlM59FWK6dvZaFE9/9oAG2AUSJL8Q7LskYGZCwkW7/mLysxtuFhiZ/SBf2IhCaZVX50=;3:3efuDEvs8p+2VQPBfTzpPYt2TBL+FAz3GzOfd2Ugs2jG3gZahV1H5tzEXALof3/QegSJnz+VmzvqY8xifdo9QYuZRiLFPgeJyqIe1IJFeQoeI1zbC47DX9qaoehtm6lG9Hj0lPZYFwEKxJ6lf0/IYUy2CyNvGwk8/i2pqZN8Em8SEYj952l6eBlYbPNERrpxlTMiHY3xSb9Ar4H06jlCoF9bAHc8teKR6forTlSh00oI5IbAvUS9BrQvKBoC0G0tpIeVb4yBeQ9Vj4BUm3C1VQ==;25:N56k7Inr3FHht5tXnzQwt3enDIzDHjlpIzkJrQfILBlrlnAVfVgn8V5lvWYc6zixyXOKx1UJV//50Vl1D/SvvBH6hhZNRHwvBEMHEla4TOhY6FltCkNt9MTaxDJ7ubWqxRa/QFdsUkSbqKVa6C7CKTV6QzX0jMiA21s0ggf9Ji1kz7Ec1oAE2Revg2WrP2ZQzmrOewbbypjXdNfHtm6HUzrWtsMTNcZDBo5GkWmAyWE6pQvhw2J8jYZcuDH/2WHRzEJMIWoeh6k60ZQdVFo2Gw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(42134001)(42139001);SRVR:CY1PR0301MB1641; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1641;20:3EvQIXAb3f6KIMQdAzYF+x0HQyCo0JNRbmEP91OPV5eQfIlKyRcT85rweSrOvzuxzhRBvWacuZxzEEHdmEmJj5iGiN04+0muzRHAN9bxq5JpOZodthvZ6EQ+pJYBy6DW6K1qZeygeGJDNHHdeHtOcpZZlKnLj05aXTKeTYEsDJqV+9BOs0XFmB4MTn1ToKfTVQoKOEJSOqcPx0RY5cFBQPrTTHqetwKziNRaaNCYz7C2C0YdBBqcLdMtnKn/dKkGzaY77D1gnX2L4+N0olAtyl327VPED+I367VSSeNtoxyIDgPi0LsEMY+5kNL9kQOq1EWdGbh/eh9g/N6oIJGVwN1Njb+4b08oTqiwSEDsIFg=;4:A11nzkw1BUHxK4MDKCCLSuDCl+z8fGpzZBzDW36eFN+hgFMZ1g9WGnJwUzjryaTDb4U4jjWuuPS8vrlEzAOqjBK6Nn1Ez4kvELvxW4edIkocwblYc5y0xDx5lfXS5nsqCBRcdPhGMGrGngco0+kAHHZAz2SN6Q01fBfCHX+31De31cCaAG1nE1v3pQr3iYNdEBjbH34YueEo0j5UT3DYoHea7HZdBrngWBHOV0dEkfWq+N3Ozwan72sVr3xCu7PWGunysDFqC/IK/b014W//XSC52H40lyOoYmR14+Hk9Vw= CY1PR0301MB1641: X-MS-Exchange-Organization-RulesExecuted X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:CY1PR0301MB1641;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB1641; X-Forefront-PRVS: 0647963F84 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR0301MB1641;23:NmeSbj4gBKB3ZcBgX5NgBhuCwavydqbEXerA9g0?= =?us-ascii?Q?PCmw0aTN3eeCT97M7Q8PhJxdRILvZcSW4ah6BD7bQ6R/ZieiytQicHTKDJ2W?= =?us-ascii?Q?PPsOBsIKWD2cfMQ5CeYXoOyEHO0hYlXaqqp6lUu6Z333Xdk5i0M3xZR5J1Po?= =?us-ascii?Q?+w9F8iobSvMjQ0/yp9Qxc91Y0iOpZJQqUwWCS+lzM+IX7GMekLiTPeKk6qj3?= =?us-ascii?Q?GLUAOf8VLouzGlRjCfmNs0SG8QWVuHprK8U2oRKl8NnjCB9fecQlqMXRKCdi?= =?us-ascii?Q?NJPaYDcTZ2XFDpRt9odjTKxQDPixhe+HL+grvNO/WAAXUVIu3VQ4hZUCTynr?= =?us-ascii?Q?Kb3VUau+FZrok6kza3mBl3ff17eAjUC9h5VfdIgucVTw/Sc6IjL+HK/JMM4u?= =?us-ascii?Q?7FMocwwemHosomIyBuwD4ae8fTHNxvvWO63XJGGfh+Lc6fK8eNcEPB9JX2mR?= =?us-ascii?Q?ArIULvDtZh5Zcg0C7iAELBVbghBBEKQfsnV0g1xAZ8XCsjhHqGiGrX7t2UDY?= =?us-ascii?Q?afdkKMkdU9zI+ZcrgB8e6IirgVFDwRQ88wT76udb8zWBmKSBfZGwQHT+Z6Ym?= =?us-ascii?Q?r2SGkICyZS4S5sMBquO9VkbE2NAawaRnJWvOpyx4x9XAb98gpQZGJORs1JQj?= =?us-ascii?Q?7Wfy/t1tDz6A5WKev/hz/DFX1lY22xFMzPItxQeWK8NJAR+4EXEqbu0VxpDb?= =?us-ascii?Q?4EtNheSvdU9JwZYBatNP57H8yu8VbwyCXFiPqiujvTelFxLw5i6UjPpZUZQa?= =?us-ascii?Q?kxjtYzx+oS02BWpmKFC87Hw9GRzo/CHSChVT0y3uSF+DcsLDzreGMEi/1oGD?= =?us-ascii?Q?FXbSTIVJHC00oj99wsrquo5DWvDtoZ3rUQbG1UQFCGw3GS/Jneu2r0LTUk5Q?= =?us-ascii?Q?pwOBjOoJwl9h3pcEEtMXZfaAm+A6z/tT/BrjsQo6Hr4pxz7u+zqFQv/6W0FH?= =?us-ascii?Q?j1ZSNFxIsHKmhFT3I7XGJi6E2oIeQaG9qgldT2cLnc3xvWFDMHURv3lrDsiw?= =?us-ascii?Q?haM+5mvTDPa+lg8R51FKYTQy+0Tv9hnUSG4sApdKhInvIkLe62mYiXwp30Dr?= =?us-ascii?Q?qpfde0IXlqMapXuSDLTB/T3NC/TBzMb3C4G+r7vCsq72PJ4//PLihX8jTgwV?= =?us-ascii?Q?6e6RmclaL/9I=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB1641;5:SvItv1uuxKI6r4iMTp26drCbD97r9eDuy3E6TzGIq78MfUPHWxF1+6fe32aRvosaXF6xM+X5iE4d9IIjCIH/KAZt8HFVE98GP90gnMKEEBVHtUqfeEIifZd2M1FxVwjNPquAoS6McxFsf8zc3McAdg==;24:yGUMk0uVFWZ5+d4wROeSEZUn9GhqF+oZDNxkUeDohA/8idVxCVg2QOTr1OMAQuDTPHxzbtsjhw1w5IKPJKqQG1zXq2tWgecZmqasTb1Tobo=;20:5AljS1QnkkwIZAsOwli3w5SdjcTM6J4FIhmIGyoV2yjIe8uh2QYXWNpRiexvkGqjl1uDfPvgn+lWhJ7J8Ra4Ew== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2015 03:31:02.0191 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.158.2];Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB1641 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 23, 2015 at 05:11:35PM -0700, Michael Turquette wrote: > Quoting Dong Aisheng (2015-07-22 07:08:10) > > Ping... > > > > On Wed, Jul 15, 2015 at 08:29:56PM +0800, Dong Aisheng wrote: > > > On Wed, Jul 15, 2015 at 08:25:24PM +0800, Dong Aisheng wrote: > > > > Hi Mike, > > > > > > > > On Wed, May 27, 2015 at 09:09:19PM -0700, Michael Turquette wrote: > > > > > Quoting Dong Aisheng (2015-05-14 06:28:59) > > > > > > __clk_set_parent_after() actually used the second argument then we > > > > > > could put this duplicate logic in there and call it with a different > > > > > > order of arguments in the success vs. error paths in this function. > > > > > > > > > > > > Cc: Mike Turquette > > > > > > Cc: Stephen Boyd > > > > > > Suggested-by: Stephen Boyd > > > > > > Signed-off-by: Dong Aisheng > > > > > > > > > > Patch looks good to me. > > > > > > > > > > Also just noticed that the second argument to __clk_set_parent_after is > > > > > never used :-( > > > > > > > > > > > > > Ping... > > > > > > > > I did not see this patch series in your tree for v4.2 rc. > > > > Is this got missed? > > Dong Aisheng, > > Yes it was missed. My apologies. Can you refresh it and re-send? > Will do it. Thanks Regards Dong Aisheng > Thanks, > Mike > > > > > > > > > > > Updated Mike's email address. > > > > > > Regards > > > Dong Aisheng > > > > > > > Regards > > > > Dong Aisheng > > > > > > > > > Regards, > > > > > Mike > > > > > > > > > > > --- > > > > > > drivers/clk/clk.c | 8 +------- > > > > > > 1 file changed, 1 insertion(+), 7 deletions(-) > > > > > > > > > > > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c > > > > > > index 659f2b0..0e813ea 100644 > > > > > > --- a/drivers/clk/clk.c > > > > > > +++ b/drivers/clk/clk.c > > > > > > @@ -1159,14 +1159,8 @@ static int __clk_set_parent(struct clk_core *core, struct clk_core *parent, > > > > > > flags = clk_enable_lock(); > > > > > > clk_reparent(core, old_parent); > > > > > > clk_enable_unlock(flags); > > > > > > + __clk_set_parent_after(core, old_parent, parent); > > > > > > > > > > > > - if (core->prepare_count) { > > > > > > - flags = clk_enable_lock(); > > > > > > - clk_core_disable(core); > > > > > > - clk_core_disable(parent); > > > > > > - clk_enable_unlock(flags); > > > > > > - clk_core_unprepare(parent); > > > > > > - } > > > > > > return ret; > > > > > > } > > > > > > > > > > > > -- > > > > > > 1.9.1 > > > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/