From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753213AbbGXG2g (ORCPT ); Fri, 24 Jul 2015 02:28:36 -0400 Received: from mga03.intel.com ([134.134.136.65]:2992 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750911AbbGXG2d (ORCPT ); Fri, 24 Jul 2015 02:28:33 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,536,1432623600"; d="scan'208";a="611980105" Date: Fri, 24 Jul 2015 12:00:19 +0530 From: Vinod Koul To: Julia Lawall Cc: Alex Smith , Zubair.Kakakhel@imgtec.com, dmaengine@vger.kernel.org, Vaishali Thakkar , linux-kernel@vger.kernel.org Subject: Re: question about drivers/dma/dma-jz4780.c Message-ID: <20150724063019.GP29916@localhost> References: <55ACAEC5.7090000@imgtec.com> <20150721041558.GE23525@localhost> <55AFA7F9.20600@imgtec.com> <20150723172110.GB29916@localhost> <20150724054226.GO29916@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 24, 2015 at 07:51:28AM +0200, Julia Lawall wrote: > > Yes for dmaengine drivers I do ask this question which typically ends up in > > driver invoking devm_irq_free() in driver's remove callback > > > > IMHO don't think devm irq calls are very useful, they do make stuff > > complicate > > Would it be better then to just go back to request_irq (or whatever is > appropriate in this case). It would seem that the devm property can never > be relied on, so there is no point to use it. Yes I do think that is right way in this case -- ~Vinod