From: Peter Zijlstra <peterz@infradead.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ingo Molnar <mingo@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Andy Lutomirski <luto@amacapital.net>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org,
Stephane Eranian <eranian@google.com>,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH RFC] perf: x86: Improve accuracy of perf/sched clock
Date: Fri, 24 Jul 2015 17:03:01 +0200 [thread overview]
Message-ID: <20150724150301.GJ19282@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1437745195-28219-1-git-send-email-adrian.hunter@intel.com>
On Fri, Jul 24, 2015 at 04:39:55PM +0300, Adrian Hunter wrote:
> @@ -251,17 +253,17 @@ static void set_cyc2ns_scale(unsigned long cpu_khz, int cpu)
> rdtscll(tsc_now);
> ns_now = cycles_2_ns(tsc_now);
>
> - /*
> - * Compute a new multiplier as per the above comment and ensure our
> - * time function is continuous; see the comment near struct
> - * cyc2ns_data.
> - */
I'd leave this comment, but update the one this refers to; esp. the bit
that explains why 10.
Also, I think you can remove the definition of CYC2NS_SCALE_FACTOR.
Other than that, seems like a good idea.
prev parent reply other threads:[~2015-07-24 15:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 13:39 [PATCH RFC] perf: x86: Improve accuracy of perf/sched clock Adrian Hunter
2015-07-24 15:03 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150724150301.GJ19282@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox