[PATCH v2 0/7] Making the generic ACPI GSI layer irqdomain aware

Marc Zyngier
2015-07-23T13:05:32Z

The irqdomain code is not entierely really ACPI friendly, as it has
some built-in knowledge of the device-tree. Nothing too harmful, but
enough to scare the ARM ACPI developpers which end up with their own
version of the square wheel.

This small patch series adapt the irqdomain code to remove the hurdles
that prevent the full blown irqdomain subsystem to be used on ACPI,
creates an interface between the GSI layer and the irqdomain, and as
an example, convert the ARM GIC ACPI support to use irqdomains as
originally intended.

Overall, this gives us a way to use irqdomains on both DT and ACPI
enabled platforms, having very little changes made to the actual
drivers (other than the probing infrastructure). Because we keep the
flow of information between the various layers identical between ACPI
and DT, we immediately benefit from the existing infrastructure.

I'd really like to hear what people think of that approach, as it
looks to me a lot simpler than the other approaches currently put on
the list. The "convert the GSI information to be DT friendly" is
admitedly not very pretty, but I see it as a stepping stone towards
unifying the two structures.

This has been test-booted on Juno, is based on my irq/ncpi-msi-v3
branch, and available at:

git://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git irq/gsi-irq-domain-v2

* From v1:
- Improved my Coccinelle foo and hopefully caught all the
irq_domain.of_node users this time
- Decoupled acpi_irq_model from domain_token. These are now two
separate values that can be set independently
- Moved the duty of populating acpi_gsi_descriptor to the interrupt
controller, as it keeps the knowledge of the mapping with
of_phandle_args in a single location
- Generic accessor to set acpi_irq_model, domain_token and the
populate function all in one go from the interrupt controller
- General cleanup

Marc Zyngier (7):
genirq: irqdomain: Use an accessor for the of_node field
genirq: irqdomain: Remove irqdomain dependency on struct device_node
genirq: irqdomain: Add irq_create_acpi_mapping
acpi: gsi: Always perform an irq domain lookup
acpi: gsi: Add acpi_set_irq_model to initialize the GSI layer
irqchip: GIC: Switch ACPI support to stacked domains
acpi: gsi: Cleanup acpi_register_gsi

arch/c6x/platforms/megamod-pic.c | 2 +-
arch/mips/cavium-octeon/octeon-irq.c | 4 +-
arch/powerpc/platforms/cell/axon_msi.c | 2 +-
arch/powerpc/platforms/cell/spider-pic.c | 9 ++-
arch/powerpc/platforms/pasemi/msi.c | 6 +-
arch/powerpc/platforms/powernv/opal-irqchip.c | 2 +-
arch/powerpc/sysdev/ehv_pic.c | 3 +-
arch/powerpc/sysdev/fsl_msi.c | 2 +-
arch/powerpc/sysdev/i8259.c | 3 +-
arch/powerpc/sysdev/ipic.c | 3 +-
arch/powerpc/sysdev/mpic.c | 3 +-
arch/powerpc/sysdev/mpic_msi.c | 2 +-
arch/powerpc/sysdev/qe_lib/qe_ic.c | 3 +-
drivers/acpi/gsi.c | 60 +++++++++++------
drivers/gpio/gpio-sodaville.c | 2 +-
drivers/irqchip/exynos-combiner.c | 2 +-
drivers/irqchip/irq-atmel-aic-common.c | 2 +-
drivers/irqchip/irq-crossbar.c | 4 +-
drivers/irqchip/irq-gic-v2m.c | 2 +-
drivers/irqchip/irq-gic-v3-its.c | 2 +-
drivers/irqchip/irq-gic-v3.c | 2 +-
drivers/irqchip/irq-gic.c | 45 +++++++++----
drivers/irqchip/irq-hip04.c | 2 +-
drivers/irqchip/irq-mtk-sysirq.c | 2 +-
drivers/irqchip/irq-s3c24xx.c | 4 +-
drivers/irqchip/irq-tegra.c | 4 +-
drivers/irqchip/irq-vf610-mscm-ir.c | 5 +-
drivers/spmi/spmi-pmic-arb.c | 2 +-
include/linux/acpi.h | 14 ++++
include/linux/irqchip/arm-gic.h | 2 +-
include/linux/irqdomain.h | 67 +++++++++++--------
kernel/irq/irqdomain.c | 95 +++++++++++++++++++++------
32 files changed, 247 insertions(+), 115 deletions(-)

--
2.1.4