From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754398AbbGXQ06 (ORCPT ); Fri, 24 Jul 2015 12:26:58 -0400 Received: from foss.arm.com ([217.140.101.70]:46078 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754304AbbGXQ0y (ORCPT ); Fri, 24 Jul 2015 12:26:54 -0400 Date: Fri, 24 Jul 2015 17:26:54 +0100 From: Will Deacon To: Catalin Marinas Cc: "Jonathan (Zhixiong) Zhang" , "fu.wei@linaro.org" , "al.stone@linaro.org" , "bp @ alien8 . de Matt Fleming" , "rjw@rjwysocki.net" , "linux-kernel@vger.kernel.org" , "linaro-acpi@lists.linaro.org" Subject: Re: [PATCH V7 3/5] arm64: mm: add PROT_DEVICE_nGnRnE and PROT_NORMAL_WT Message-ID: <20150724162654.GB21177@arm.com> References: <1437515960-16812-1-git-send-email-zjzhang@codeaurora.org> <1437515960-16812-4-git-send-email-zjzhang@codeaurora.org> <20150724161500.GV3550@e104818-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150724161500.GV3550@e104818-lin.cambridge.arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 24, 2015 at 05:15:00PM +0100, Catalin Marinas wrote: > On Tue, Jul 21, 2015 at 10:59:18PM +0100, Jonathan (Zhixiong) Zhang wrote: > > * > > * n = AttrIndx[2:0] > > * n MAIR > > @@ -303,12 +303,14 @@ ENTRY(__cpu_setup) > > * DEVICE_GRE 010 00001100 > > * NORMAL_NC 011 01000100 > > * NORMAL 100 11111111 > > + * NORMAL_WT 101 10111011 > > I don't think the write allocation hint makes much sense for WT memory > (though it shouldn't cause issues either). Just use 10101010. The EFI spec actually specifies the 1011 1011 encoding, so I think we should follow that. Will