From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753632AbbGXUBF (ORCPT ); Fri, 24 Jul 2015 16:01:05 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:53967 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752562AbbGXUBE (ORCPT ); Fri, 24 Jul 2015 16:01:04 -0400 Date: Fri, 24 Jul 2015 13:01:02 -0700 From: Greg Kroah-Hartman To: Joshua Clayton Cc: Larry Finger , Florian Schilhabel , devel@driverdev.osuosl.org, Tapasweni Pathak , Vaishali Thakkar , linux-kernel@vger.kernel.org, Sudip Mukherjee Subject: Re: [PATCH 3/5] staging: rtl8712: remove duplicate struct Message-ID: <20150724200102.GA22385@kroah.com> References: <1563309.ulsDW4l8M4@diplodocus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1563309.ulsDW4l8M4@diplodocus> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 23, 2015 at 09:57:50PM -0700, Joshua Clayton wrote: > struct ndis_wlan_bssid_ex is a dopelganger of > struct wlan_bssid_ex, and is used about a third as often > > Switch all instances to wlan_bssid_ex > > This also gets rid of a use of typedef NDIS_802_11_RATES_EX > > Signed-off-by: Joshua Clayton > --- > drivers/staging/rtl8712/rtl871x_cmd.c | 17 ++++++------- > drivers/staging/rtl8712/rtl871x_cmd.h | 4 +-- > drivers/staging/rtl8712/rtl871x_event.h | 2 +- > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 10 ++++---- > drivers/staging/rtl8712/rtl871x_mlme.c | 35 > +++++++++++++-------------- > drivers/staging/rtl8712/rtl871x_mlme.h | 2 +- > drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 6 ++--- > drivers/staging/rtl8712/wlan_bssdef.h | 23 ++---------------- > 8 files changed, 38 insertions(+), 61 deletions(-) > > diff --git a/drivers/staging/rtl8712/rtl871x_cmd.c > b/drivers/staging/rtl8712/rtl871x_cmd.c > index f07050d..ef71829 100644 > --- a/drivers/staging/rtl8712/rtl871x_cmd.c > +++ b/drivers/staging/rtl8712/rtl871x_cmd.c > @@ -456,9 +456,7 @@ u8 r8712_createbss_cmd(struct _adapter *padapter) > INIT_LIST_HEAD(&pcmd->list); > pcmd->cmdcode = _CreateBss_CMD_; > pcmd->parmbuf = (unsigned char *)pdev_network; > - pcmd->cmdsz = r8712_get_ndis_wlan_bssid_ex_sz(( > - struct ndis_wlan_bssid_ex *) > - pdev_network); > + pcmd->cmdsz = r8712_get_wlan_bssid_ex_sz(pdev_network); > pcmd->rsp = NULL; > pcmd->rspsz = 0; > /* notes: translate IELength & Length after assign to cmdsz; */ > @@ -471,7 +469,7 @@ u8 r8712_createbss_cmd(struct _adapter *padapter) > > u8 r8712_joinbss_cmd(struct _adapter *padapter, struct wlan_network > *pnetwork) Patch is line-wrapped and can not be applied :( Can you redo this whole series and resend properly? Your 0/5 email needs a subject as well... thanks, greg k-h