From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754357AbbGXUjy (ORCPT ); Fri, 24 Jul 2015 16:39:54 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:55085 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754091AbbGXUjw (ORCPT ); Fri, 24 Jul 2015 16:39:52 -0400 Date: Fri, 24 Jul 2015 13:39:52 -0700 From: Greg Kroah-Hartman To: Jakub Sitnicki Cc: Larry Finger , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCH RESEND] staging: rtl8188eu: don't duplicate ieee80211 WLAN_EID_* constants Message-ID: <20150724203952.GA27809@kroah.com> References: <20150723183707.GB29830@kroah.com> <1437750758-17120-1-git-send-email-jsitnicki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437750758-17120-1-git-send-email-jsitnicki@gmail.com> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 24, 2015 at 05:12:38PM +0200, Jakub Sitnicki wrote: > linux/ieee80211.h already defines constants for information element IDs. > Include it where needed, resolve discrepancies in naming, and remove the > duplicated definitions. > > While at it, wrap a line that was too long and remove extra parentheses > in an expression that mixes only equality and logical operators. This patch doesn't apply at all. Also, don't do more than one thing in a single patch, this should be broken up into multiple ones. thanks, greg k-h