Re: [PATCH v2] cpufreq: Avoid attempts to create duplicate symbolic links

Rafael J. Wysocki
2015-07-27T13:18:17Z

On Monday, July 27, 2015 07:57:18 AM Viresh Kumar wrote:
> On 26-07-15, 00:46, Rafael J. Wysocki wrote:
> > OK, I'll prepare a new version of that patch then, but as I said this
> > choice means that we'll be creating the links to the policy at the
> > policy creation time going forward.
>
> Atleast for the rc fix, we should do exactly this. Right.
>
> But we can rethink about getting both my earlier patches merged for
> 4.3, which did this:
>
> - Keep adding CPUs to a global mask, which didn't had a existing
> policy and were offline when subsys-callback for called for them.
> - And then create the links only when the subsys callback is called
> for CPUs, for which policy already exist, as Russell suggested.

Say the subsys add callback runs for a CPU and it doesn't have a policy.
If it is offline, we ignore it and the add callback won't be executed
for it again.

In turn, if it is online, we create a policy for it and we should (right
away) link the policy to all of the CPUs that were offline when the subsys add
callback was called for them. That's what we do today.

Is there anything missing in that?

Thanks,
Rafael