From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754982AbbGYOaq (ORCPT ); Sat, 25 Jul 2015 10:30:46 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:51186 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754858AbbGYOap (ORCPT ); Sat, 25 Jul 2015 10:30:45 -0400 Date: Sat, 25 Jul 2015 17:30:24 +0300 From: Dan Carpenter To: Jakub Sitnicki Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Larry Finger Subject: Re: [PATCH RESEND] staging: rtl8188eu: don't duplicate ieee80211 WLAN_EID_* constants Message-ID: <20150725143024.GZ5371@mwanda> References: <20150723183707.GB29830@kroah.com> <1437750758-17120-1-git-send-email-jsitnicki@gmail.com> <20150724203952.GA27809@kroah.com> <877fpo8hbm.fsf@frog.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <877fpo8hbm.fsf@frog.home> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 25, 2015 at 04:05:52PM +0200, Jakub Sitnicki wrote: > On Fri, Jul 24, 2015 at 10:39 PM CEST, Greg Kroah-Hartman wrote: > > On Fri, Jul 24, 2015 at 05:12:38PM +0200, Jakub Sitnicki wrote: > >> linux/ieee80211.h already defines constants for information element IDs. > >> Include it where needed, resolve discrepancies in naming, and remove the > >> duplicated definitions. > >> > >> While at it, wrap a line that was too long and remove extra parentheses > >> in an expression that mixes only equality and logical operators. > > > > This patch doesn't apply at all. > > My mistake, sorry. I've generated it against v4.2-rc3. > Do it against git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next regards, dan carpenter