From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755256AbbGZQbP (ORCPT ); Sun, 26 Jul 2015 12:31:15 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:21438 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755184AbbGZQbL (ORCPT ); Sun, 26 Jul 2015 12:31:11 -0400 Date: Sun, 26 Jul 2015 19:31:06 +0300 From: Dan Carpenter To: Geliang Tang Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: comedi: make "unsigned int __force *" shorter Message-ID: <20150726163106.GA5371@mwanda> References: <1437919294-3833-1-git-send-email-geliangtang@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437919294-3833-1-git-send-email-geliangtang@163.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 26, 2015 at 10:01:34PM +0800, Geliang Tang wrote: > Use macro "uip" instead of "unsigned int __force *", like "vuip" in > arch/alpha/include/asm/core_cia.h. > > Signed-off-by: Geliang Tang The original is easier to understand. Don't add pointless abstractions just to get around a single 80 character line. regards, dan carpenter