Re: [PATCH v2 24/25] arch: remove ioremap_wt, replace with arch_memremap

Christoph Hellwig
2015-07-27T08:03:53Z

> +++ b/arch/frv/include/asm/io.h
> @@ -17,8 +17,6 @@
>
> #ifdef __KERNEL__
>
> -#define ARCH_HAS_IOREMAP_WT
> -
> #include <linux/types.h>
> #include <asm/virtconvert.h>
> #include <asm/string.h>
> @@ -267,20 +265,17 @@ static inline void __iomem *ioremap_nocache(unsigned long physaddr, unsigned lon
> return __ioremap(physaddr, size, IOMAP_NOCACHE_SER);
> }
>
> -static inline void __iomem *ioremap_wt(unsigned long physaddr, unsigned long size)
> -{
> - return __ioremap(physaddr, size, IOMAP_WRITETHROUGH);
> -}
> -
> -static inline void __iomem *ioremap_fullcache(unsigned long physaddr, unsigned long size)
> -{
> - return __ioremap(physaddr, size, IOMAP_FULL_CACHING);
> -}

> +void *arch_memremap(resource_size_t offset, size_t size, unsigned long flags)
> +{
> + return (void *) offset;
> +}
> +EXPORT_SYMBOL(arch_memremap);

This doesn't look like a correct replacement.

Also shouldn't the replacements of ioremap_fullcache or ioremap_wc be
in the previous patch?

A few more similar issues pop up for other architectures as well.