From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752968AbbG0Ifj (ORCPT ); Mon, 27 Jul 2015 04:35:39 -0400 Received: from mail-pd0-f180.google.com ([209.85.192.180]:34579 "EHLO mail-pd0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752279AbbG0Ifh (ORCPT ); Mon, 27 Jul 2015 04:35:37 -0400 Date: Mon, 27 Jul 2015 14:05:31 +0530 From: Viresh Kumar To: Bartlomiej Zolnierkiewicz Cc: Thomas Abraham , Sylwester Nawrocki , Michael Turquette , Kukjin Kim , Kukjin Kim , Krzysztof Kozlowski , Tomasz Figa , Lukasz Majewski , Heiko Stuebner , Chanwoo Choi , Kevin Hilman , Javier Martinez Canillas , Tobias Jakobi , Anand Moon , linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/7] cpufreq: opp: fix handling of turbo modes Message-ID: <20150727083531.GC31611@linux> References: <1436456621-29839-1-git-send-email-b.zolnierkie@samsung.com> <1436456621-29839-3-git-send-email-b.zolnierkie@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436456621-29839-3-git-send-email-b.zolnierkie@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org $subject is a bit wrong, we aren't fixing any issue here. We are supporting a new feature and so it should be like: cpufreq: Mark boost frequencies based on OPP's turbo mode On 09-07-15, 17:43, Bartlomiej Zolnierkiewicz wrote: > Turbo modes should be marked with CPUFREQ_BOOST_FREQ flag in > the frequency table entry. > > Cc: Tomasz Figa > Cc: Michael Turquette > Cc: Javier Martinez Canillas > Cc: Thomas Abraham > Cc: Viresh Kumar > Signed-off-by: Bartlomiej Zolnierkiewicz > --- > drivers/cpufreq/cpufreq_opp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/cpufreq/cpufreq_opp.c b/drivers/cpufreq/cpufreq_opp.c > index 773bcde..f0cf502 100644 > --- a/drivers/cpufreq/cpufreq_opp.c > +++ b/drivers/cpufreq/cpufreq_opp.c > @@ -75,6 +75,8 @@ int dev_pm_opp_init_cpufreq_table(struct device *dev, > } > freq_table[i].driver_data = i; > freq_table[i].frequency = rate / 1000; > + if (dev_pm_opp_get_turbo_mode_setting(opp) == true) > + freq_table[i].flags |= CPUFREQ_BOOST_FREQ; > } > > freq_table[i].driver_data = i; Rest look fine. -- viresh