Re: [PATCH v2 2/7] cpufreq: opp: fix handling of turbo modes

Bartlomiej Zolnierkiewicz
2015-07-27T10:25:10Z

Hi,

On Monday, July 27, 2015 02:05:31 PM Viresh Kumar wrote:
> $subject is a bit wrong, we aren't fixing any issue here. We are
> supporting a new feature and so it should be like:

Have you read my explanation of the issue?

With your OPP-v2 patches cpufreq-dt picks turbo frequencies and uses
them as normal ones.

(More at: http://www.spinics.net/lists/arm-kernel/msg430397.html)

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> cpufreq: Mark boost frequencies based on OPP's turbo mode
>
> On 09-07-15, 17:43, Bartlomiej Zolnierkiewicz wrote:
> > Turbo modes should be marked with CPUFREQ_BOOST_FREQ flag in
> > the frequency table entry.
> >
> > Cc: Tomasz Figa <tomasz.figa@gmail.com>
> > Cc: Michael Turquette <mturquette@baylibre.com>
> > Cc: Javier Martinez Canillas <javier@dowhile0.org>
> > Cc: Thomas Abraham <thomas.ab@samsung.com>
> > Cc: Viresh Kumar <viresh.kumar@linaro.org>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > ---
> > drivers/cpufreq/cpufreq_opp.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/cpufreq/cpufreq_opp.c b/drivers/cpufreq/cpufreq_opp.c
> > index 773bcde..f0cf502 100644
> > --- a/drivers/cpufreq/cpufreq_opp.c
> > +++ b/drivers/cpufreq/cpufreq_opp.c
> > @@ -75,6 +75,8 @@ int dev_pm_opp_init_cpufreq_table(struct device *dev,
> > }
> > freq_table[i].driver_data = i;
> > freq_table[i].frequency = rate / 1000;
> > + if (dev_pm_opp_get_turbo_mode_setting(opp) == true)
> > + freq_table[i].flags |= CPUFREQ_BOOST_FREQ;
> > }
> >
> > freq_table[i].driver_data = i;
>
> Rest look fine.