From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752596AbbG0Kvn (ORCPT ); Mon, 27 Jul 2015 06:51:43 -0400 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:40470 "EHLO e06smtp16.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751124AbbG0Kvm (ORCPT ); Mon, 27 Jul 2015 06:51:42 -0400 X-Helo: d06dlp03.portsmouth.uk.ibm.com X-MailFrom: heiko.carstens@de.ibm.com X-RcptTo: linux-kernel@vger.kernel.org Date: Mon, 27 Jul 2015 12:51:33 +0200 From: Heiko Carstens To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, jasonbaron0@gmail.com, bp@alien8.de, luto@amacapital.net, tglx@linutronix.de, rostedt@goodmis.org, will.deacon@arm.com, liuj97@gmail.com, rabin@rab.in, ralf@linux-mips.org, ddaney@caviumnetworks.com, benh@kernel.crashing.org, michael@ellerman.id.au, davem@davemloft.net Subject: Re: [RFC][PATCH 6/7] jump_label: Add a new static_key interface Message-ID: <20150727105133.GC8278@osiris> References: <20150724175209.814173117@infradead.org> <20150724175823.120997211@infradead.org> <20150727104510.GS19282@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150727104510.GS19282@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15072710-0025-0000-0000-0000062CA0D5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 27, 2015 at 12:45:10PM +0200, Peter Zijlstra wrote: > --- a/arch/s390/include/asm/jump_label.h > +++ b/arch/s390/include/asm/jump_label.h > +static __always_inline bool arch_static_branch_jump(struct static_key *key, bool branch) > +{ > + asm_volatile_goto("0: brcl 15, %l[l_yes]\n" > + ".pushsection __jump_table, \"aw\"\n" > + ".balign 8\n" > + ".quad 0b, %l[label], %0\n" > + ".popsection\n" > + : : "X" (&((char *)key)[branch]) : : label); The above should have been asm_volatile_goto("0: brcl 15,%l[label]\n" (label instead of l_yes). Just recognized this, sorry..