From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org,
jasonbaron0@gmail.com, bp@alien8.de, luto@amacapital.net,
tglx@linutronix.de, rostedt@goodmis.org, will.deacon@arm.com,
liuj97@gmail.com, rabin@rab.in, ralf@linux-mips.org,
ddaney@caviumnetworks.com, benh@kernel.crashing.org,
michael@ellerman.id.au, davem@davemloft.net
Subject: Re: [RFC][PATCH 6/7] jump_label: Add a new static_key interface
Date: Mon, 27 Jul 2015 12:52:42 +0200 [thread overview]
Message-ID: <20150727105242.GD8278@osiris> (raw)
In-Reply-To: <20150727105036.GO18673@twins.programming.kicks-ass.net>
On Mon, Jul 27, 2015 at 12:50:36PM +0200, Peter Zijlstra wrote:
> On Mon, Jul 27, 2015 at 12:47:55PM +0200, Peter Zijlstra wrote:
> > On Mon, Jul 27, 2015 at 12:20:46PM +0200, Heiko Carstens wrote:
> > > On Mon, Jul 27, 2015 at 11:52:25AM +0200, Peter Zijlstra wrote:
> > > > > +static __always_inline bool arch_static_branch_jump(struct static_key *key, bool branch)
> > > > > +{
> > > > > + asm_volatile_goto("0: j %l[l_yes]\n"
> > > >
> > > > Looking at the s390 version of jump_label_make_branch(), this should
> > > > have been:
> > > >
> > > > "brcl 15, %l[l_yes]\n"
> > > >
> > > > I suppose?
> > >
> > > Yes. I wanted to test your version, but I assume you will send
> > > an updated version soon?
> >
> > I just send out updated patches for 5/6. They boot without issue on my
> > x86_64.
>
> Also, it helps if you convert one static_key user into something that'll
> trigger this new code.
>
> The one I picked is unfortunately rather x86 specific.
Yeah, just did that and it crashes ;)
Hopefully I'll have time to look into it today.
next prev parent reply other threads:[~2015-07-27 10:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 17:52 [RFC][PATCH 0/7] jump_label: Another (better) static_key interface Peter Zijlstra
2015-07-24 17:52 ` [RFC][PATCH 1/7] jump_label: Rename JUMP_LABEL_{EN,DIS}ABLE Peter Zijlstra
2015-07-24 17:52 ` [RFC][PATCH 2/7] jump_label: Rename JUMP_LABEL_TYPE_* Peter Zijlstra
2015-07-24 17:52 ` [RFC][PATCH 3/7] jump_label: Add jump_entry_key() helper Peter Zijlstra
2015-07-24 17:52 ` [RFC][PATCH 4/7] jump_label: Add static_key_{en,dis}able() helpers Peter Zijlstra
2015-07-24 17:52 ` [RFC][PATCH 5/7] jump_label: Rework update logic Peter Zijlstra
2015-07-27 9:07 ` Peter Zijlstra
2015-07-27 10:47 ` Peter Zijlstra
2015-07-27 16:30 ` Peter Zijlstra
2015-07-28 5:54 ` Heiko Carstens
2015-07-24 17:52 ` [RFC][PATCH 6/7] jump_label: Add a new static_key interface Peter Zijlstra
2015-07-27 9:24 ` Peter Zijlstra
2015-07-27 9:52 ` Peter Zijlstra
2015-07-27 10:20 ` Heiko Carstens
2015-07-27 10:47 ` Peter Zijlstra
2015-07-27 10:50 ` Peter Zijlstra
2015-07-27 10:52 ` Heiko Carstens [this message]
2015-07-27 11:03 ` Peter Zijlstra
2015-07-27 14:39 ` Peter Zijlstra
2015-07-27 10:45 ` Peter Zijlstra
2015-07-27 10:51 ` Heiko Carstens
2015-07-24 17:52 ` [RFC][PATCH 7/7] x86, tsc: Employ static_branch_likely() Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150727105242.GD8278@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=ddaney@caviumnetworks.com \
--cc=jasonbaron0@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuj97@gmail.com \
--cc=luto@amacapital.net \
--cc=michael@ellerman.id.au \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rabin@rab.in \
--cc=ralf@linux-mips.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).