From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752688AbbG0KxI (ORCPT ); Mon, 27 Jul 2015 06:53:08 -0400 Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:44200 "EHLO e06smtp14.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751088AbbG0KxF (ORCPT ); Mon, 27 Jul 2015 06:53:05 -0400 X-Helo: d06dlp02.portsmouth.uk.ibm.com X-MailFrom: heiko.carstens@de.ibm.com X-RcptTo: linux-kernel@vger.kernel.org Date: Mon, 27 Jul 2015 12:52:42 +0200 From: Heiko Carstens To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, jasonbaron0@gmail.com, bp@alien8.de, luto@amacapital.net, tglx@linutronix.de, rostedt@goodmis.org, will.deacon@arm.com, liuj97@gmail.com, rabin@rab.in, ralf@linux-mips.org, ddaney@caviumnetworks.com, benh@kernel.crashing.org, michael@ellerman.id.au, davem@davemloft.net Subject: Re: [RFC][PATCH 6/7] jump_label: Add a new static_key interface Message-ID: <20150727105242.GD8278@osiris> References: <20150724175209.814173117@infradead.org> <20150724175823.120997211@infradead.org> <20150727095225.GR19282@twins.programming.kicks-ass.net> <20150727102046.GB8278@osiris> <20150727104755.GU19282@twins.programming.kicks-ass.net> <20150727105036.GO18673@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150727105036.GO18673@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15072710-0017-0000-0000-000004DD3A39 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 27, 2015 at 12:50:36PM +0200, Peter Zijlstra wrote: > On Mon, Jul 27, 2015 at 12:47:55PM +0200, Peter Zijlstra wrote: > > On Mon, Jul 27, 2015 at 12:20:46PM +0200, Heiko Carstens wrote: > > > On Mon, Jul 27, 2015 at 11:52:25AM +0200, Peter Zijlstra wrote: > > > > > +static __always_inline bool arch_static_branch_jump(struct static_key *key, bool branch) > > > > > +{ > > > > > + asm_volatile_goto("0: j %l[l_yes]\n" > > > > > > > > Looking at the s390 version of jump_label_make_branch(), this should > > > > have been: > > > > > > > > "brcl 15, %l[l_yes]\n" > > > > > > > > I suppose? > > > > > > Yes. I wanted to test your version, but I assume you will send > > > an updated version soon? > > > > I just send out updated patches for 5/6. They boot without issue on my > > x86_64. > > Also, it helps if you convert one static_key user into something that'll > trigger this new code. > > The one I picked is unfortunately rather x86 specific. Yeah, just did that and it crashes ;) Hopefully I'll have time to look into it today.