From: Mike Snitzer <snitzer@redhat.com>
To: Colin King <colin.king@canonical.com>
Cc: Alasdair Kergon <agk@redhat.com>,
dm-devel@redhat.com, Neil Brown <neilb@suse.com>,
linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: dm cache: fix alloc_bitset check that always evaluates as false
Date: Mon, 27 Jul 2015 08:15:29 -0400 [thread overview]
Message-ID: <20150727121529.GC2312@redhat.com> (raw)
In-Reply-To: <1437666479-24633-1-git-send-email-colin.king@canonical.com>
On Thu, Jul 23 2015 at 11:47P -0400,
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> static analysis by cppcheck has found a check on alloc_bitset that
> always evaluates as false and hence never finds an allocation failure:
>
> [drivers/md/dm-cache-policy-smq.c:1689]: (warning) Logical conjunction
> always evaluates to false: !EXPR && EXPR.
>
> Fix this by removing the incorrect mq->cache_hit_bits check
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied for 4.2-rc5 inclussion, thanks:
https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-next&id=134bf30c06f057d6b8d90132e8f8b3cd2be79572
prev parent reply other threads:[~2015-07-27 12:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 15:47 [PATCH] dm cache: fix alloc_bitset check that always evaluates as false Colin King
2015-07-27 12:15 ` Mike Snitzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150727121529.GC2312@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=colin.king@canonical.com \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox