public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: linux-xtensa@linux-xtensa.org, linux-kernel@vger.kernel.org,
	Chris Zankel <chris@zankel.net>, Marc Gauthier <marc@cadence.com>
Subject: Re: [PATCH v2 12/13] xtensa: implement fake NMI
Date: Mon, 27 Jul 2015 17:14:37 +0200	[thread overview]
Message-ID: <20150727151437.GY19282@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1437208216-15729-13-git-send-email-jcmvbkbc@gmail.com>

On Sat, Jul 18, 2015 at 11:30:15AM +0300, Max Filippov wrote:
> In case perf IRQ is the highest of the medium-level IRQs, and is alone
> on its level, it may be treated as NMI:
> - LOCKLEVEL is defined to be one level less than EXCM level,
> - IRQ masking never lowers current IRQ level,
> - new fake exception cause code, EXCCAUSE_MAPPED_NMI is assigned to that
>   IRQ; new second level exception handler, do_nmi, assigned to it
>   handles it as NMI,
> - atomic operations in configurations without s32c1i still need to mask
>   all interrupts.
> 
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> ---
>  arch/xtensa/include/asm/atomic.h    | 10 ++--
>  arch/xtensa/include/asm/cmpxchg.h   |  4 +-
>  arch/xtensa/include/asm/irqflags.h  | 22 ++++++++-
>  arch/xtensa/include/asm/processor.h | 31 ++++++++++++-
>  arch/xtensa/kernel/entry.S          | 93 +++++++++++++++++++++++++++++++------
>  arch/xtensa/kernel/irq.c            |  8 ++++
>  arch/xtensa/kernel/perf_event.c     |  6 ++-
>  arch/xtensa/kernel/traps.c          | 26 +++++++++++
>  arch/xtensa/kernel/vectors.S        | 10 +++-
>  9 files changed, 183 insertions(+), 27 deletions(-)

Looks about right, I've not really gone over the asm bits through.

Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>

  parent reply	other threads:[~2015-07-27 15:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-18  8:30 [PATCH v2 00/13] Support hardware perf counters on xtensa Max Filippov
2015-07-18  8:30 ` [PATCH v2 01/13] xtensa: clean up Kconfig dependencies for custom cores Max Filippov
2015-07-18  8:30 ` [PATCH v2 02/13] xtensa: keep exception/interrupt stack continuous Max Filippov
2015-07-18  8:30 ` [PATCH v2 03/13] xtensa: move oprofile stack tracing to stacktrace.c Max Filippov
2015-07-18  8:30 ` [PATCH v2 04/13] xtensa: select PERF_USE_VMALLOC for cache-aliasing configurations Max Filippov
2015-07-18  8:30 ` [PATCH v2 05/13] xtensa: add profiling IRQ type to xtensa_irq_map Max Filippov
2015-07-18  8:30 ` [PATCH v2 06/13] xtensa: count software page fault perf events Max Filippov
2015-07-18  8:30 ` [PATCH v2 07/13] xtensa: implement counting and sampling " Max Filippov
2015-08-06 19:46   ` Arnaldo Carvalho de Melo
2015-08-07  9:13     ` Peter Zijlstra
2015-08-07 12:03       ` Max Filippov
2015-08-07 13:12         ` Arnaldo Carvalho de Melo
2015-07-18  8:30 ` [PATCH v2 08/13] perf tools: xtensa: add DWARF register names Max Filippov
2015-08-07  7:22   ` [tip:perf/core] perf tools xtensa: Add " tip-bot for Max Filippov
2015-07-18  8:30 ` [PATCH v2 09/13] xtensa: reorganize irq flags tracing Max Filippov
2015-07-18  8:30 ` [PATCH v2 10/13] xtensa: fix kernel register spilling Max Filippov
2015-07-18  8:30 ` [PATCH v2 11/13] xtensa: don't touch EXC_TABLE_FIXUP in _switch_to Max Filippov
2015-07-18  8:30 ` [PATCH v2 12/13] xtensa: implement fake NMI Max Filippov
2015-07-27 14:36   ` Max Filippov
2015-07-27 15:14   ` Peter Zijlstra [this message]
2015-07-18  8:30 ` [PATCH v2 13/13] xtensa: drop unused irq_err_count Max Filippov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150727151437.GY19282@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=chris@zankel.net \
    --cc=jcmvbkbc@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xtensa@linux-xtensa.org \
    --cc=marc@cadence.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox