From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753996AbbG0TPB (ORCPT ); Mon, 27 Jul 2015 15:15:01 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:36569 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752718AbbG0TPA (ORCPT ); Mon, 27 Jul 2015 15:15:00 -0400 Date: Mon, 27 Jul 2015 21:14:28 +0200 From: Mario Bambagini To: Dan Carpenter Cc: oleg.drokin@intel.com, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, andreas.dilger@intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] staging: lustre: fixed 80-char rule Message-ID: <20150727191428.GA17859@lynx> References: <1437841372-30713-1-git-send-email-mario.bambagini@gmail.com> <1437841372-30713-2-git-send-email-mario.bambagini@gmail.com> <20150726191411.GB5371@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150726191411.GB5371@mwanda> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 26, 2015 at 10:14:11PM +0300, Dan Carpenter wrote: > On Sat, Jul 25, 2015 at 06:22:52PM +0200, Mario Bambagini wrote: > > This patch fixes 2 lines longer than 80 chars > > > > The first one is a function whose argument has been moved to next line. > > The second one is a comment split on two lines > > > > The script checkpatch does not complain anymore > > > > Signed-off-by: Mario Bambagini > > --- > > drivers/staging/lustre/lustre/llite/llite_capa.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/staging/lustre/lustre/llite/llite_capa.c b/drivers/staging/lustre/lustre/llite/llite_capa.c > > index 119f017..1f72066 100644 > > --- a/drivers/staging/lustre/lustre/llite/llite_capa.c > > +++ b/drivers/staging/lustre/lustre/llite/llite_capa.c > > @@ -70,7 +70,8 @@ static unsigned long long ll_capa_renewal_retries; > > > > static int ll_update_capa(struct obd_capa *ocapa, struct lustre_capa *capa); > > > > -static inline void update_capa_timer(struct obd_capa *ocapa, unsigned long expiry) > > +static inline void update_capa_timer(struct obd_capa *ocapa, > > + unsigned long expiry) > > This is wrong. Run your patch through checkpatch.pl --strict and it > will help you. > > regards, > dan carpenter > Thank you for the hint. I'll resend the set of patches. regards MB