From: Viresh Kumar <viresh.kumar@linaro.org>
To: Pan Xinhui <xinhuix.pan@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"mnipxh@163.com" <mnipxh@163.com>,
"yanmin_zhang@linux.intel.com" <yanmin_zhang@linux.intel.com>
Subject: Re: [PATCH] cpufreq: Add scaling frequency range support
Date: Tue, 28 Jul 2015 09:59:45 +0530 [thread overview]
Message-ID: <20150728042945.GE1229@linux> (raw)
In-Reply-To: <55B6F7C3.8040405@intel.com>
On 28-07-15, 11:32, Pan Xinhui wrote:
> From: Pan Xinhui <xinhuix.pan@intel.com>
>
> Userspace at most time do cpufreq tests very much inconveniently.
> Currently they have to echo min and max cpu freq separately like below:
> echo 480000 > /sys/devices/system/cpu/cpu0/cpufreq/scaling_min_freq
> echo 2240000 > /sys/devices/system/cpu/cpu0/cpufreq/scaling_max_freq
>
> Add scaling_freq_range cpufreq attr to support userspace's demand.
> Therefore it's easier for testers to write readable scripts like below:
> echo 480000-2240000 >
> /sys/devices/system/cpu/cpu0/cpufreq/scaling_freq_range
I don't think this brings any good change, we already have support for
that with min/max freqs and I don't see how scripts can be less
readable with that.
So, why to add redundant files at all? Also note that we can't remove
the old interface as that will break the ABI.
--
viresh
next prev parent reply other threads:[~2015-07-28 4:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 3:32 [PATCH] cpufreq: Add scaling frequency range support Pan Xinhui
2015-07-28 4:29 ` Viresh Kumar [this message]
2015-07-28 4:53 ` Pan Xinhui
2015-07-29 0:18 ` Rafael J. Wysocki
2015-07-29 9:59 ` Pan Xinhui
2015-07-29 10:04 ` Pan Xinhui
2015-07-29 11:01 ` Viresh Kumar
2015-07-29 22:40 ` Rafael J. Wysocki
2015-07-28 5:20 ` Viresh Kumar
2015-07-28 7:02 ` [PATCH V2] " Pan Xinhui
2015-07-28 7:09 ` Viresh Kumar
2015-07-29 0:15 ` [PATCH] " Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150728042945.GE1229@linux \
--to=viresh.kumar@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mnipxh@163.com \
--cc=rjw@rjwysocki.net \
--cc=xinhuix.pan@intel.com \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).