From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752792AbbG1E3w (ORCPT ); Tue, 28 Jul 2015 00:29:52 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:34094 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751088AbbG1E3v (ORCPT ); Tue, 28 Jul 2015 00:29:51 -0400 Date: Tue, 28 Jul 2015 09:59:45 +0530 From: Viresh Kumar To: Pan Xinhui Cc: "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" , "rjw@rjwysocki.net" , "mnipxh@163.com" , "yanmin_zhang@linux.intel.com" Subject: Re: [PATCH] cpufreq: Add scaling frequency range support Message-ID: <20150728042945.GE1229@linux> References: <55B6F7C3.8040405@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55B6F7C3.8040405@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28-07-15, 11:32, Pan Xinhui wrote: > From: Pan Xinhui > > Userspace at most time do cpufreq tests very much inconveniently. > Currently they have to echo min and max cpu freq separately like below: > echo 480000 > /sys/devices/system/cpu/cpu0/cpufreq/scaling_min_freq > echo 2240000 > /sys/devices/system/cpu/cpu0/cpufreq/scaling_max_freq > > Add scaling_freq_range cpufreq attr to support userspace's demand. > Therefore it's easier for testers to write readable scripts like below: > echo 480000-2240000 > > /sys/devices/system/cpu/cpu0/cpufreq/scaling_freq_range I don't think this brings any good change, we already have support for that with min/max freqs and I don't see how scripts can be less readable with that. So, why to add redundant files at all? Also note that we can't remove the old interface as that will break the ABI. -- viresh